REGRESSION (259678@main): [ iOS17 ] ASSERTION FAILED: task.callback f…

…or fast/dom/Orientation/no-orientation-change-event-when-unparenting-view.html result of a consistent crash

https://bugs.webkit.org/show_bug.cgi?id=267934
rdar://121454476

Reviewed by Ryosuke Niwa.

Make sure we clear the `rotationDidEndCallback` delegate on the WKWebView once
it has been called. Otherwise, we may end up trying to call the callback several
times, which would hit the assertion we were seeing.

* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::simulateRotation):

Canonical link: https://commits.webkit.org/275423@main

Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

@@ -1110,9 +1110,9 @@ static UIDeviceOrientation toUIDeviceOrientation(DeviceOrientation orientation)
 {
     auto callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);
     webView().rotationDidEndCallback = makeBlockPtr([this, protectedThis = Ref { *this }, callbackID] {
-        if (!m_context)
-            return;
-        m_context->asyncTaskComplete(callbackID);
+        if (m_context)
+            m_context->asyncTaskComplete(callbackID);
+        webView().rotationDidEndCallback = nil;
     }).get();
 
 #if HAVE(UI_WINDOW_SCENE_GEOMETRY_PREFERENCES)