Skip to content

Commit

Permalink
[webkitpy] Remove AbstractTestResults
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=266122

Reviewed by Jonathan Bedard.

AbstractTestResults now has a single subclass, LayoutTestResults, so it
may as well not exist.

* Tools/Scripts/webkitpy/common/net/abstracttestresults.py: Removed.
* Tools/Scripts/webkitpy/common/net/abstracttestresults_unittest.py: Removed.
* Tools/Scripts/webkitpy/common/net/layouttestresults.py:
(LayoutTestResults):
* Tools/Scripts/webkitpy/test/main.py:
(main):

Canonical link: https://commits.webkit.org/272048@main
  • Loading branch information
gsnedders committed Dec 14, 2023
1 parent 26e5ef8 commit f437eb5
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 93 deletions.
45 changes: 0 additions & 45 deletions Tools/Scripts/webkitpy/common/net/abstracttestresults.py

This file was deleted.

43 changes: 0 additions & 43 deletions Tools/Scripts/webkitpy/common/net/abstracttestresults_unittest.py

This file was deleted.

5 changes: 1 addition & 4 deletions Tools/Scripts/webkitpy/common/net/layouttestresults.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@

import logging

from webkitpy.common.net.abstracttestresults import AbstractTestResults
from webkitpy.common.net.resultsjsonparser import ParsedJSONResults
from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup, SoupStrainer
from webkitpy.layout_tests.models import test_results
from webkitpy.layout_tests.models import test_failures

_log = logging.getLogger(__name__)
Expand All @@ -46,7 +43,7 @@ def path_for_layout_test(test_name):
# FIXME: This should be unified with ResultsSummary or other NRWT layout tests code
# in the layout_tests package.
# This doesn't belong in common.net, but we don't have a better place for it yet.
class LayoutTestResults(AbstractTestResults):
class LayoutTestResults(object):
@classmethod
def results_from_string(cls, string):
if not string:
Expand Down
1 change: 0 additions & 1 deletion Tools/Scripts/webkitpy/test/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ def main():
"webkitpy.common.editdistance_unittest",
"webkitpy.common.find_files_unittest",
"webkitpy.common.memoized_unittest",
"webkitpy.common.net.abstracttestresults_unittest",
"webkitpy.common.net.bugzilla.attachment_unittest",
"webkitpy.common.net.bugzilla.bug_unittest",
"webkitpy.common.net.bugzilla.bugzilla_unittest",
Expand Down

0 comments on commit f437eb5

Please sign in to comment.