Skip to content

Commit

Permalink
Add Test Case of a Japanese character inside ruby is overflowed from …
Browse files Browse the repository at this point in the history
…background of ruby

https://bugs.webkit.org/show_bug.cgi?id=117013

Reviewed by Alan Baradlay.

This adds tests for coverage of baseline matching for ruby element
with Japanese character while being vertically aligned not overflowing
from background of ruby.

Test Case Credit to Yuki Sekiguchi <yuki.sekiguchi@access-company.com>.

* LayoutTests/fast/writing-mode/inline-block-baseline.html: Add Test Case
* LayoutTests/fast/writing-mode/inline-block-baseline-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/275942@main
  • Loading branch information
Ahmad Saleem committed Mar 12, 2024
1 parent 804fa8c commit f5aca85
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
18 changes: 18 additions & 0 deletions LayoutTests/fast/writing-mode/inline-block-baseline-expected.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8" />
</head>
<body>
Left side of a japanese character "国" should vertically align with baseline of "a".
<div style="writing-mode: vertical-rl; font-size: 4em">
<span>a
<div style="background-color: green; display: inline-block">a<br></div><span style="visibility: hidden"></span>
</span>
<br>
<span>a
<ruby style="background-color: green;"><rt style="background-color: red; opacity: 0.5">くに</rt></ruby><span style="visibility: hidden"></span>
</span>
</div>
</body>
</html>
19 changes: 19 additions & 0 deletions LayoutTests/fast/writing-mode/inline-block-baseline.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8" />
</head>
<body>
Left side of a japanese character "国" should vertically align with baseline of "a".
<div style="writing-mode: vertical-rl; font-size: 4em">
<span>a
<div style="background-color: green; display: inline-block">a<br></div>
</span>
<br>
<span>a
<ruby style="background-color: green;"><rt style="background-color: red; opacity: 0.5">くに</rt></ruby>
</span>
<br>
</div>
</body>
</html>

0 comments on commit f5aca85

Please sign in to comment.