Skip to content
Permalink
Browse files
2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebProcess.pro:
2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

Canonical link: https://commits.webkit.org/73188@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Apr 11, 2011
1 parent b752930 commit f669fcb395d84ecb6307ba2e0f9979a71cad5b58
Showing 5 changed files with 32 additions and 2 deletions.
@@ -1,3 +1,16 @@
2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Eric Seidel.

Require no undefined symbols during compilation.

[Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
https://bugs.webkit.org/show_bug.cgi?id=54896

Add -Wl,--no-undefined to catch missing symbols early.

* WebProcess.pro:

2011-04-09 Geoffrey Garen <ggaren@apple.com>

Not reviewed.
@@ -27,7 +27,7 @@ linux-* {
QMAKE_RPATHDIR = \$\$ORIGIN/../lib $$QMAKE_RPATHDIR
MY_RPATH = $$join(QMAKE_RPATHDIR, ":")

QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\'
QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\' -Wl,--no-undefined
QMAKE_RPATHDIR =
} else {
QMAKE_RPATHDIR = $$OUTPUT_DIR/lib $$QMAKE_RPATHDIR
@@ -1,3 +1,17 @@
2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Eric Seidel.

Require no undefined symbols during compilation.

[Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
https://bugs.webkit.org/show_bug.cgi?id=54896

Add -Wl,--no-undefined to catch missing symbols early.

* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:

2011-04-10 Kevin Ollivier <kevino@theolliviers.com>

[wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
@@ -80,3 +80,6 @@ unix:!mac:!symbian:!embedded {
TARGET = WTRInjectedBundle
DESTDIR = $$OUTPUT_DIR/lib
!CONFIG(standalone_package): CONFIG -= app_bundle
linux-* {
QMAKE_LFLAGS += -Wl,--no-undefined
}
@@ -57,7 +57,7 @@ linux-* {
QMAKE_RPATHDIR = \$\$ORIGIN/../lib $$QMAKE_RPATHDIR
MY_RPATH = $$join(QMAKE_RPATHDIR, ":")

QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\'
QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\' -Wl,--no-undefined
QMAKE_RPATHDIR =
} else {
QMAKE_RPATHDIR = $$OUTPUT_DIR/lib $$QMAKE_RPATHDIR

0 comments on commit f669fcb

Please sign in to comment.