Skip to content

Commit

Permalink
Merge r220449 - REGRESSION: 2 test262/test/language/statements/async-…
Browse files Browse the repository at this point in the history
…function failures

https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @Skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

* stress/async-await-syntax.js:
* stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

* runtime/Options.h:
  • Loading branch information
gskachkov authored and carlosgcampos committed Aug 14, 2017
1 parent d4ff6aa commit f70e161
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 4 deletions.
13 changes: 13 additions & 0 deletions JSTests/ChangeLog
@@ -1,3 +1,16 @@
2017-08-09 Oleksandr Skachkov <gskachkov@gmail.com>

REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

* stress/async-await-syntax.js:
* stress/async-iteration-syntax.js:

2017-08-08 Yusuke Suzuki <utatane.tea@gmail.com>

Unreviewed, gardening test262 for Promise resolve / reject function length
Expand Down
3 changes: 0 additions & 3 deletions JSTests/stress/async-await-syntax.js
Expand Up @@ -193,10 +193,7 @@ function testSyntaxError(script, message) {

testSyntaxError(`var asyncArrowFn = async() => await;`);

testSyntax(`var asyncFn = async function*() {}`);
testSyntax(`async function* asyncGenerator() {}`);
testSyntaxError(`var O = { *async asyncGeneratorMethod() {} };`);
testSyntax(`var O = { async *asyncGeneratorMethod() {} };`);
testSyntaxError(`var O = { async asyncGeneratorMethod*() {} };`);

testSyntaxError(`var asyncFn = async function(x = await 1) { return x; }`);
Expand Down
4 changes: 4 additions & 0 deletions JSTests/stress/async-iteration-syntax.js
@@ -1,3 +1,7 @@
// This test requires enableAsyncIterator to be enabled at run time.
//@ skip


var assert = function (result, expected, message = "") {
if (result !== expected) {
throw new Error('Error in assert. Expected "' + expected + '" but was "' + result + '":' + message );
Expand Down
11 changes: 11 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,14 @@
2017-08-09 Oleksandr Skachkov <gskachkov@gmail.com>

REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

Switch off useAsyncIterator by default

* runtime/Options.h:

2017-08-08 Filip Pizlo <fpizlo@apple.com>

ICs should do caging
Expand Down
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/Options.h
Expand Up @@ -448,7 +448,7 @@ typedef const char* optionString;
\
v(bool, useWebAssembly, true, Normal, "Expose the WebAssembly global object.") \
\
v(bool, useAsyncIterator, true, Normal, "Allow to use Async Iterator in JS.") \
v(bool, useAsyncIterator, false, Normal, "Allow to use Async Iterator in JS.") \
\
v(bool, failToCompileWebAssemblyCode, false, Normal, "If true, no Wasm::Plan will sucessfully compile a function.") \
v(size, webAssemblyPartialCompileLimit, 5000, Normal, "Limit on the number of bytes a Wasm::Plan::compile should attempt before checking for other work.") \
Expand Down

0 comments on commit f70e161

Please sign in to comment.