Skip to content
Permalink
Browse files
[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=229250

Reviewed by Wenson Hsieh.

Disable the assertion when Web Thread is enabled for now.

* wtf/CheckedRef.h:
(WTF::SingleThreadIntegralWrapper::assertThread const):


Canonical link: https://commits.webkit.org/240654@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rniwa committed Aug 19, 2021
1 parent f3435a1 commit f8a029b168e4c6d44a188d0abf94fd1d4b938646
Showing 2 changed files with 18 additions and 2 deletions.
@@ -1,3 +1,15 @@
2021-08-18 Ryosuke Niwa <rniwa@webkit.org>

[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=229250

Reviewed by Wenson Hsieh.

Disable the assertion when Web Thread is enabled for now.

* wtf/CheckedRef.h:
(WTF::SingleThreadIntegralWrapper::assertThread const):

2021-08-18 Megan Gardner <megan_gardner@apple.com>

Remove unneeded UIKitSPI declarations
@@ -248,18 +248,22 @@ class SingleThreadIntegralWrapper {
SingleThreadIntegralWrapper& operator--();

private:
#if ASSERT_ENABLED && !USE(WEB_THREAD)
void assertThread() const { ASSERT(m_thread.ptr() == &Thread::current()); }
#else
constexpr void assertThread() const { }
#endif

IntegralType m_value;
#if ASSERT_ENABLED
#if ASSERT_ENABLED && !USE(WEB_THREAD)
Ref<Thread> m_thread;
#endif
};

template <typename IntegralType>
inline SingleThreadIntegralWrapper<IntegralType>::SingleThreadIntegralWrapper(IntegralType value)
: m_value { value }
#if ASSERT_ENABLED
#if ASSERT_ENABLED && !USE(WEB_THREAD)
, m_thread { Thread::current() }
#endif
{ }

0 comments on commit f8a029b

Please sign in to comment.