-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Cocoa] MediaCapabilities spatial rendering checks fail on capable HW…
… with built-in sound output https://bugs.webkit.org/show_bug.cgi?id=265614 rdar://114214068 Reviewed by Jer Noble. On macOS, use SPI got get spatial audio preferences to see if spatial audio playback is supported. On iOS, switch from using the shared audio presentation output context to AVAudioSession, which makes it possible to see if the currently audio route has a port that supports spatial playback. * Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.cpp: * Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.h: * Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/PAL/pal/spi/cocoa/AudioToolboxSPI.h: * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::setSupportsSpatialAudioPlayback): (WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlaybackForConfiguration): * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlayback): * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h: * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::MediaSessionManagerCocoa): (WebCore::MediaSessionManagerCocoa::updateSessionState): (WebCore::MediaSessionManagerCocoa::supportsSpatialAudioPlaybackForConfiguration): * Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.h: * Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm: (MediaSessionHelper::activeAudioRouteSupportsSpatialPlaybackDidChange): (MediaSessionHelper::updateActiveAudioRouteSupportsSpatialPlayback): (MediaSessionHelper::setActiveAudioRouteSupportsSpatialPlayback): (-[WebMediaSessionHelper initWithCallback:]): (-[WebMediaSessionHelper spatialPlaybackCapabilitiesChanged:]): * Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h: * Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::activeAudioRouteSupportsSpatialPlaybackDidChange): (WebCore::MediaSessionManagerCocoa::supportsSpatialAudioPlaybackForConfiguration): * Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp: (WebCore::computeMediaCapabilitiesInfo): * Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp: (WebKit::RemoteMediaSessionHelperProxy::activeAudioRouteSupportsSpatialPlaybackDidChange): * Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h: * Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp: (WebKit::wrapperVTable): * Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp: (WebKit::RemoteMediaSessionHelper::activeAudioRouteSupportsSpatialPlaybackDidChange): * Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h: * Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.messages.in: Canonical link: https://commits.webkit.org/271504@main
- Loading branch information
1 parent
fb8f991
commit f8df164
Showing
21 changed files
with
228 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.