Skip to content

Commit

Permalink
REGRESSION (268639@main): [ macOS wk2 ] http/tests/navigation/keyboar…
Browse files Browse the repository at this point in the history
…d-events-during-provisional-subframe-navigation.html is a flaky timeout

https://bugs.webkit.org/show_bug.cgi?id=270275
rdar://123801060

Reviewed by Alex Christensen.

268639@main made a change to reference the focused frame in the UI process when sending key events.

This test should make sure the UI process has up to date frame focus before sending the key event.

* LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:

Canonical link: https://commits.webkit.org/275618@main
  • Loading branch information
charliewolfe committed Mar 4, 2024
1 parent 81bff4c commit f937e7b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@

console.log("Pressing \"z\" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html.");
window.focus();
eventSender.keyDown("z", internals.accessKeyModifiers());
setTimeout(() => {
eventSender.keyDown("z", internals.accessKeyModifiers());
}, 50)
});
</script>
</body>
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/mac-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2016,6 +2016,4 @@ webkit.org/b/270319 [ Ventura ] accessibility/datetime/input-time-label-value.ht
[ Sonoma+ ] imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-div.html [ Pass ]
[ Sonoma+ ] imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-div.html [ Pass ]

webkit.org/b/270275 http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html [ Pass Timeout ]

webkit.org/b/270368 [ Monterey+ Debug x86_64 ] fast/mediastream/microphone-change-while-muted.html [ Pass Failure ]

0 comments on commit f937e7b

Please sign in to comment.