-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix about:blank document.referrer initialization
https://bugs.webkit.org/show_bug.cgi?id=242965 Reviewed by Darin Adler. This change makes WebKit conform to the requirement in the HTML spec at https://html.spec.whatwg.org/#creating-a-new-browsing-context that a new browsing context is created with its referrer set to "the serialization of [its] creator's URL" — that is, the creator’s full URL, without regard to Referrer Policy — which makes the WebKit behavior in this case interoperable with existing behavior in Blink. Otherwise, without this change, the referrer is set to an “origin string” (origin + trailing slash) — which breaks conformance with the spec, and breaks interop/compat with Blink. * LayoutTests/http/wpt/html/browsers/windows/browsing-context.html: * LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-expected.txt: Removed. * Source/WebCore/loader/SubframeLoader.cpp: (WebCore::FrameLoader::SubframeLoader::loadSubframe): Canonical link: https://commits.webkit.org/273830@main
- Loading branch information
1 parent
89d1bc2
commit fd0640d
Showing
4 changed files
with
13 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...Tests/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
PASS Check that browsing context has new, ready HTML document | ||
PASS Check that new document nodes extant, empty | ||
FAIL Check the document properties corresponding to the creator browsing context assert_equals: The document's referrer should be its creator document's URL. expected "http://localhost:8800/html/browsers/windows/browsing-context.html" but got "http://localhost:8800/" | ||
PASS Check the document properties corresponding to the creator browsing context | ||
|
5 changes: 0 additions & 5 deletions
5
.../glib/imported/w3c/web-platform-tests/html/browsers/windows/browsing-context-expected.txt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters