-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 69d07a6. rdar://problem/111793617
When selecting Live Text in Safari on iOS, the selection handles move away from the selection when zooming https://bugs.webkit.org/show_bug.cgi?id=259964 rdar://111793617 Reviewed by Wenson Hsieh. UIKit now scales the selection handles when zooming and updates their position accordingly. Since WebKit is also scaling them ourselves, this results in a position that's offset from the selection proportional to the zoom amount. Fix by no longer scaling the selection handles in WebKit. * LayoutTests/resources/ui-helper.js: (window.UIHelper.getSelectionEndGrabberViewShapePathDescription.return.new.Promise.): (window.UIHelper.getSelectionEndGrabberViewShapePathDescription.return.new.Promise): (window.UIHelper.getSelectionEndGrabberViewShapePathDescription): * Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm: (-[WKTextSelectionRect _customHandleInfo]): * Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * Tools/TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::selectionEndGrabberViewShapePathDescription const): * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h: * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::selectionEndGrabberViewShapePathDescription const): Canonical link: https://commits.webkit.org/266753@main Canonical link: https://commits.webkit.org/265870.322@safari-7616.1.27.10-branch
- Loading branch information
Showing
6 changed files
with
76 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters