[Curl][Soup] Remove CredentialStorage[Curl|Soup].cpp

https://bugs.webkit.org/show_bug.cgi?id=259135 Reviewed by Fujii Hironori. CredentialStorage::getFromPersistentStorage is not used in WebKit2. So curl and soup port don't need the function. Therefore, to reduce maintenance costs, remove CredentialStorage[Curl|Soup].cpp. * Source/WebCore/platform/Curl.cmake: * Source/WebCore/platform/SourcesSoup.txt: * Source/WebCore/platform/network/CredentialStorage.h: * Source/WebCore/platform/network/curl/CredentialStorageCurl.cpp: Removed. * Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp: Removed. Canonical link: https://commits.webkit.org/265988@main
WebKit · Jul 12, 2023 · fea01c2 · fea01c2
1 parent 7a87c11
commit fea01c2
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 89 deletions.
diff --git a/Source/WebCore/platform/Curl.cmake b/Source/WebCore/platform/Curl.cmake
@@ -8,7 +8,6 @@ list(APPEND WebCore_SOURCES
     platform/network/curl/CookieJarDB.cpp
     platform/network/curl/CookieStorageCurl.cpp
     platform/network/curl/CookieUtil.cpp
-    platform/network/curl/CredentialStorageCurl.cpp
     platform/network/curl/CurlContext.cpp
     platform/network/curl/CurlFormDataStream.cpp
     platform/network/curl/CurlMultipartHandle.cpp

diff --git a/Source/WebCore/platform/SourcesSoup.txt b/Source/WebCore/platform/SourcesSoup.txt
@@ -26,7 +26,6 @@ platform/network/soup/CertificateInfoSoup.cpp
 platform/network/soup/CookieSoup.cpp
 platform/network/soup/CookieStorageSoup.cpp
 platform/network/soup/CredentialSoup.cpp
-platform/network/soup/CredentialStorageSoup.cpp
 platform/network/soup/NetworkStorageSessionSoup.cpp
 platform/network/soup/ResourceErrorSoup.cpp
 platform/network/soup/ResourceRequestSoup.cpp

diff --git a/Source/WebCore/platform/network/CredentialStorage.h b/Source/WebCore/platform/network/CredentialStorage.h
@@ -46,8 +46,10 @@ class CredentialStorage {
     WEBCORE_EXPORT void removeCredentialsWithOrigin(const SecurityOriginData&);
     WEBCORE_EXPORT void clearCredentials();
 
+#if PLATFORM(COCOA)
     // OS credential storage.
     WEBCORE_EXPORT static Credential getFromPersistentStorage(const ProtectionSpace&);
+#endif
 
     // These methods work for authentication schemes that support sending credentials without waiting for a request. E.g., for HTTP Basic authentication scheme
     // a client should assume that all paths at or deeper than the depth of a known protected resource share are within the same protection space.

diff --git a/Source/WebCore/platform/network/curl/CredentialStorageCurl.cpp b/Source/WebCore/platform/network/curl/CredentialStorageCurl.cpp
diff --git a/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp b/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp