Skip to content

Commit

Permalink
[iOS] fast/events/ios/rotation/basic-rotation.html is constantly fail…
Browse files Browse the repository at this point in the history
…ing.

https://bugs.webkit.org/show_bug.cgi?id=271442
rdar://125210995

Unreviewed test expectations adjustment.

The previous expectations were accurate for the iPhone SE (1st
generation), but we have defaulted to running layout tests on iPhone 12
(since 256495@main). As such, this patch updates the dimensions to match
the iPhone 12.

* LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt:
* LayoutTests/fast/events/ios/rotation/basic-rotation.html:
* LayoutTests/platform/ios-wk2/TestExpectations:

Remove the failing expectation.

* LayoutTests/platform/ios/TestExpectations:

Unskip fast/events/ios/rotation since the timeouts are no longer
reproducing.

Canonical link: https://commits.webkit.org/276589@main
  • Loading branch information
aprotyas committed Mar 23, 2024
1 parent 26bbf59 commit fec218f
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 23 deletions.
20 changes: 10 additions & 10 deletions LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Before rotation
PASS window.innerWidth is 320
PASS window.innerHeight is 548
In orientationchange event handler:
FAIL window.innerWidth should be 568. Was 320.
FAIL window.innerHeight should be 320. Was 548.

PASS window.innerWidth is 390
PASS window.innerHeight is 797
In resize event handler:
PASS window.innerWidth is 568
PASS window.innerHeight is 320
PASS window.innerWidth is 844
PASS window.innerHeight is 390

In orientationchange event handler:
PASS window.innerWidth is 844
PASS window.innerHeight is 390

After rotation
PASS window.innerWidth is 568
PASS window.innerHeight is 320
PASS window.innerWidth is 844
PASS window.innerHeight is 390
Rotation test.
16 changes: 8 additions & 8 deletions LayoutTests/fast/events/ios/rotation/basic-rotation.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,30 +21,30 @@
function doTest()
{
debug('Before rotation');
shouldBe("window.innerWidth", "320");
shouldBe("window.innerHeight", "548");
shouldBe("window.innerWidth", "390");
shouldBe("window.innerHeight", "797");
if (!window.testRunner)
return;

testRunner.runUIScript(getRotationUIScript(), function(result) {
debug('After rotation');
shouldBe("window.innerWidth", "568");
shouldBe("window.innerHeight", "320");
shouldBe("window.innerWidth", "844");
shouldBe("window.innerHeight", "390");

if (window.testRunner)
testRunner.notifyDone();
});
}
window.addEventListener('resize', function() {
debug('In resize event handler:');
shouldBe("window.innerWidth", "568");
shouldBe("window.innerHeight", "320");
shouldBe("window.innerWidth", "844");
shouldBe("window.innerHeight", "390");
debug('');
}, false);
window.addEventListener('orientationchange', function() {
debug('In orientationchange event handler:');
shouldBe("window.innerWidth", "568");
shouldBe("window.innerHeight", "320");
shouldBe("window.innerWidth", "844");
shouldBe("window.innerHeight", "390");
debug('');
}, false);

Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/ios-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2767,6 +2767,4 @@ http/tests/security/clipboard/copy-paste-html-across-origin-sanitizes-html.html
http/tests/security/clipboard/copy-paste-html-across-origin-strips-mso-list.html [ Pass Failure ]
imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-report-only-policy-works-with-external-hash-policy.html [ Pass Failure ]

webkit.org/b/271442 fast/events/ios/rotation/basic-rotation.html [ Failure ]

webkit.org/b/271445 fast/events/ios/rotation/resize-iframe-after-orientation-change.html [ Pass Failure ]
3 changes: 0 additions & 3 deletions LayoutTests/platform/ios/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -4457,9 +4457,6 @@ imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-tex

webkit.org/b/259228 [ Release ] fast/dom/lazy-image-loading-document-leak.html [ Pass Failure ]

# rdar://102857582 (iOS17-iOS-Simulator queues timing out before finishing layout tests)
fast/events/ios/rotation/ [ Skip ]

# These tests require compile-time flags in WebKit that are only enabled in iOS17. They were marked as Skip in
# https://bugs.webkit.org/show_bug.cgi?id=248545 — re-enable them here.
fast/images/animations-resume-from-last-displayed-frame.html [ Pass ]
Expand Down

0 comments on commit fec218f

Please sign in to comment.