-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[iOS] fast/events/ios/rotation/basic-rotation.html is constantly fail…
…ing. https://bugs.webkit.org/show_bug.cgi?id=271442 rdar://125210995 Unreviewed test expectations adjustment. The previous expectations were accurate for the iPhone SE (1st generation), but we have defaulted to running layout tests on iPhone 12 (since 256495@main). As such, this patch updates the dimensions to match the iPhone 12. * LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt: * LayoutTests/fast/events/ios/rotation/basic-rotation.html: * LayoutTests/platform/ios-wk2/TestExpectations: Remove the failing expectation. * LayoutTests/platform/ios/TestExpectations: Unskip fast/events/ios/rotation since the timeouts are no longer reproducing. Canonical link: https://commits.webkit.org/276589@main
- Loading branch information
Showing
4 changed files
with
18 additions
and
23 deletions.
There are no files selected for viewing
20 changes: 10 additions & 10 deletions
20
LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
Before rotation | ||
PASS window.innerWidth is 320 | ||
PASS window.innerHeight is 548 | ||
In orientationchange event handler: | ||
FAIL window.innerWidth should be 568. Was 320. | ||
FAIL window.innerHeight should be 320. Was 548. | ||
|
||
PASS window.innerWidth is 390 | ||
PASS window.innerHeight is 797 | ||
In resize event handler: | ||
PASS window.innerWidth is 568 | ||
PASS window.innerHeight is 320 | ||
PASS window.innerWidth is 844 | ||
PASS window.innerHeight is 390 | ||
|
||
In orientationchange event handler: | ||
PASS window.innerWidth is 844 | ||
PASS window.innerHeight is 390 | ||
|
||
After rotation | ||
PASS window.innerWidth is 568 | ||
PASS window.innerHeight is 320 | ||
PASS window.innerWidth is 844 | ||
PASS window.innerHeight is 390 | ||
Rotation test. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters