REGRESSION(267655@main): inspector/sampling-profiler/many-call-frames…

….html is a constant text failure. https://bugs.webkit.org/show_bug.cgi?id=261213 <rdar://115064790> Reviewed by Yusuke Suzuki. 267655@main introduced throwing a TypeError for top-level global fun shadowing non-configurable global properties like "top", aligning JSC with other runtimes. This change renames "top" function in a Web Inspector test to fix it. * LayoutTests/inspector/sampling-profiler/many-call-frames-expected.txt: * LayoutTests/inspector/sampling-profiler/many-call-frames.html: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/267711@main
WebKit · Sep 7, 2023 · ff020b4 · ff020b4
1 parent 39a03ba
commit ff020b4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/LayoutTests/inspector/sampling-profiler/many-call-frames-expected.txt b/LayoutTests/inspector/sampling-profiler/many-call-frames-expected.txt
@@ -4,7 +4,7 @@
 PASS: Should have seen stacktrace:
 [
   {
-    "name": "top"
+    "name": "stacktraceTop"
   },
   {
     "name": "g"

diff --git a/LayoutTests/inspector/sampling-profiler/many-call-frames.html b/LayoutTests/inspector/sampling-profiler/many-call-frames.html
@@ -17,15 +17,15 @@
 function d() { e(); }
 function e() { f(); }
 function f() { g(); }
-function g() { top(); }
+function g() { stacktraceTop(); }
 
-function top() {
+function stacktraceTop() {
     for (let i = 0; i < 10000; i++) {
         i++;
         i--;
     }
 }
-noInline(top);
+noInline(stacktraceTop);
 
 function test()
 {
@@ -39,7 +39,7 @@
                 let tree = WI.CallingContextTree.__test_makeTreeFromProtocolMessageObject(messageObject);
 
                 let trace = [
-                    {name: "top"},
+                    {name: "stacktraceTop"},
                     {name: "g"},
                     {name: "f"},
                     {name: "e"},

diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
@@ -2854,5 +2854,3 @@ webkit.org/b/261000 media/video-orientation-canvas.html [ Pass Failure ]
 [ Release ] imported/w3c/web-platform-tests/css/compositing/mix-blend-mode/mix-blend-mode-with-transform-and-preserve-3D.html [ ImageOnlyFailure ]
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
-
-webkit.org/b/261213 inspector/sampling-profiler/many-call-frames.html [ Failure ]