Skip to content

Commit

Permalink
Merge r227198 - WebDriver: driver environment not passed to pytest wh…
Browse files Browse the repository at this point in the history
…en running w3c tests

https://bugs.webkit.org/show_bug.cgi?id=181852

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-01-19
Reviewed by Carlos Alberto Lopez Perez.

That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.

* Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.run):
  • Loading branch information
carlosgcampos committed Jan 24, 2018
1 parent b6a78e3 commit ffde8c8
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,15 @@
2018-01-19 Carlos Garcia Campos <cgarcia@igalia.com>

WebDriver: driver environment not passed to pytest when running w3c tests
https://bugs.webkit.org/show_bug.cgi?id=181852

Reviewed by Carlos Alberto Lopez Perez.

That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.

* Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.run):

2018-01-19 Carlos Garcia Campos <cgarcia@igalia.com>

WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
Expand Down
Expand Up @@ -150,5 +150,6 @@ def run(self, test, timeout, expectations):
'WD_PORT': str(self.protocol.session_config['port']),
'WD_CAPABILITIES': json.dumps(self.protocol.session_config['capabilities']),
'WD_SERVER_CONFIG': json.dumps(self.server_config)}
env.update(WebKitDriverServer.test_env)
args = ['--strict', '-p', 'no:mozlog']
return pytest_runner.run(test, args, timeout, env, expectations)

0 comments on commit ffde8c8

Please sign in to comment.