Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commits.webkit.org] Support compare redirect #1009

Merged
merged 0 commits into from May 26, 2022
Merged

[commits.webkit.org] Support compare redirect #1009

merged 0 commits into from May 26, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 25, 2022 •
edited by webkit-early-warning-system

427a542

[commits.webkit.org] Support compare redirect
https://bugs.webkit.org/show_bug.cgi?id=240908
<rdar://problem/93904385 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py:
(Redirector):
(Redirector.bitbucket_compare): Added.
(Redirector.trac_compare): Added.
(Redirector.github_compare): Added.
(Redirector.__init__): Define a compare function.
(CheckoutRoute):
(CheckoutRoute.find_newer): Add function to sort a commit pair.
(CheckoutRoute.__init__): Add 'compare' endpoints.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:
(CheckoutRouteUnittest.test_compare):
(CheckoutRouteUnittest.test_compare_trac):

Canonical link: https://commits.webkit.org/250999@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this May 25, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Local Build labels May 25, 2022
@JonWBedard JonWBedard requested a review from dewei-zhu May 25, 2022 16:33
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 25, 2022
dewei-zhu
dewei-zhu approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard removed merging-blocked Applied to prevent a change from being merged Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Local Build labels May 25, 2022
@JonWBedard JonWBedard force-pushed the eng/commits-webkit-org-Support-compare-redirect branch from eac6533 to 734d2af Compare May 25, 2022 20:00
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Local Build merge-queue Applied to send a pull request to merge-queue labels May 25, 2022
@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels May 26, 2022
@JonWBedard JonWBedard added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 26, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/commits-webkit-org-Support-compare-redirect branch from 734d2af to 427a542 Compare May 26, 2022 05:21
@webkit-early-warning-system webkit-early-warning-system merged commit 427a542 into WebKit:main May 26, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294869 (250999@main): https://commits.webkit.org/250999@main

Reviewed commits have been landed. Closing PR #1009 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2022
@JonWBedard JonWBedard deleted the eng/commits-webkit-org-Support-compare-redirect branch June 14, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @webkit-early-warning-system @dewei-zhu