Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in find-feature-flags script #10102

Merged

Conversation

@donny-dont donny-dont added the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2023
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #10102

@JonWBedard
Copy link
Member

@mokjasmine, it's the commit message that matters, not the PR description. Just edit your commit message with git commit --amend to match what you have the PR description here and then git-webkit pr or git push fork fix-typo-find-feature-flags -f to force-update the branch

@mokjasmine mokjasmine changed the title fix typo in _CHOICES Fix typo in find-feature-flags script Feb 14, 2023
@donny-dont donny-dont added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Feb 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=252259

Reviewed by Don Olmstead.

Fix typo in find-feature-flags script. Change 'code' _CHOICES array to 'all-code' to match conditional in `_choice_set`.

-Tools/Scripts/find-feature-flags

Canonical link: https://commits.webkit.org/260274@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260274@main (14312d0): https://commits.webkit.org/260274@main

Reviewed commits have been landed. Closing PR #10102 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 14312d0 into WebKit:main Feb 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants