Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github/CODEOWNERS for Site Quirks and Sandboxes #10109

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented Feb 15, 2023

@brentfulgham brentfulgham self-assigned this Feb 15, 2023
@brentfulgham brentfulgham added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 15, 2023
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me. Thanks!

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 15, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #10109

@JonWBedard JonWBedard removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 15, 2023
@JonWBedard
Copy link
Member

@brentfulgham Looks like you left the Include a Radar link (OOPS!). in the commit message.

@brentfulgham
Copy link
Contributor Author

@brentfulgham Looks like you left the Include a Radar link (OOPS!). in the commit message.

Whoops! Will fix and land.

@brentfulgham brentfulgham force-pushed the eng/Update--githubCODEOWNERS-for-Site-Quirks-and-Sandboxes branch from 699665c to 44573dc Compare February 15, 2023 17:46
@brentfulgham brentfulgham added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 15, 2023
https://bugs.webkit.org/show_bug.cgi?id=252271

Reviewed by Per Arne Vollan.

We lost some of the automated notifications we used to have before we switched to GitHub. This
patch adds owners to a few files where we'd like to be notified of changes.

* .github/CODEOWNERS:

Canonical link: https://commits.webkit.org/260315@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Update--githubCODEOWNERS-for-Site-Quirks-and-Sandboxes branch from 44573dc to ccfd01b Compare February 15, 2023 17:51
@webkit-early-warning-system webkit-early-warning-system merged commit ccfd01b into WebKit:main Feb 15, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260315@main (ccfd01b): https://commits.webkit.org/260315@main

Reviewed commits have been landed. Closing PR #10109 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants