New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLib] Add more padding to more vtables #10163
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
mcatanzaro:eng/GLib-Add-more-padding-to-more-vtables
Feb 16, 2023
Merged
[GLib] Add more padding to more vtables #10163
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
mcatanzaro:eng/GLib-Add-more-padding-to-more-vtables
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 7d8b849) |
mcatanzaro
force-pushed
the
eng/GLib-Add-more-padding-to-more-vtables
branch
from
February 16, 2023 18:54
7d8b849
to
5453406
Compare
EWS run on previous version of this PR (hash 5453406) |
aperezdc
approved these changes
Feb 16, 2023
mcatanzaro
force-pushed
the
eng/GLib-Add-more-padding-to-more-vtables
branch
from
February 16, 2023 20:50
5453406
to
bf2a81f
Compare
https://bugs.webkit.org/show_bug.cgi?id=252052 Reviewed by Adrian Perez de Castro. Let's add more padding to these vtables for future-proofing. I am only adding a small amount of additional padding because we never used any of the previous padding and most likely that will not change. * Source/JavaScriptCore/API/glib/JSCClass.h.in: * Source/WebKit/UIProcess/API/glib/WebKitPolicyDecision.h.in: * Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp: Canonical link: https://commits.webkit.org/260396@main
webkit-early-warning-system
force-pushed
the
eng/GLib-Add-more-padding-to-more-vtables
branch
from
February 16, 2023 22:07
bf2a81f
to
7ca0c69
Compare
Committed 260396@main (7ca0c69): https://commits.webkit.org/260396@main Reviewed commits have been landed. Closing PR #10163 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7ca0c69
bf2a81f
π wincairoπ ios-simπ§ͺ ios-wk2π§ͺ gtk-wk2π§ͺ api-gtkπ π§ͺ jscπ jsc-armv7π§ͺ mac-AS-debug-wk2π§ͺ jsc-armv7-testsπ jsc-mipsπ§ͺ jsc-mips-tests