Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLib] Add more padding to more vtables #10163

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Feb 15, 2023

@mcatanzaro mcatanzaro requested a review from a team as a code owner February 15, 2023 20:51
@mcatanzaro mcatanzaro self-assigned this Feb 15, 2023
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label Feb 15, 2023
@mcatanzaro mcatanzaro force-pushed the eng/GLib-Add-more-padding-to-more-vtables branch from 7d8b849 to 5453406 Compare February 16, 2023 18:54
@mcatanzaro mcatanzaro force-pushed the eng/GLib-Add-more-padding-to-more-vtables branch from 5453406 to bf2a81f Compare February 16, 2023 20:50
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Feb 16, 2023
https://bugs.webkit.org/show_bug.cgi?id=252052

Reviewed by Adrian Perez de Castro.

Let's add more padding to these vtables for future-proofing. I am only
adding a small amount of additional padding because we never used any of
the previous padding and most likely that will not change.

* Source/JavaScriptCore/API/glib/JSCClass.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitPolicyDecision.h.in:
* Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

Canonical link: https://commits.webkit.org/260396@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260396@main (7ca0c69): https://commits.webkit.org/260396@main

Reviewed commits have been landed. Closing PR #10163 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7ca0c69 into WebKit:main Feb 16, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
4 participants