Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for visual data before accessing to avoid crash. #10181

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Check for visual data before accessing to avoid crash. #10181

merged 1 commit into from
Feb 16, 2023

Conversation

megangardner
Copy link
Contributor

@megangardner megangardner commented Feb 16, 2023 •
edited by webkit-early-warning-system

@megangardner megangardner self-assigned this Feb 16, 2023
@megangardner megangardner added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Feb 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 6649d3a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@hortont424
Copy link
Contributor

@cdumez a lovely bug found by your libcpp assertion enablement!

@megangardner megangardner added the merge-queue Applied to send a pull request to merge-queue label Feb 16, 2023
@megangardner
Check for visual data before accessing to avoid crash.
b5fa2df 
https://bugs.webkit.org/show_bug.cgi?id=252363
rdar://105522607

Reviewed by Tim Horton.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionClipRect]):

Canonical link: https://commits.webkit.org/260343@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Check-for-visual-data-before-accessing-to-avoid-crash- branch from 6649d3a to b5fa2df Compare February 16, 2023 02:28
@webkit-commit-queue
Copy link
Collaborator

Committed 260343@main (b5fa2df): https://commits.webkit.org/260343@main

Reviewed commits have been landed. Closing PR #10181 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b5fa2df into WebKit:main Feb 16, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@whsieh whsieh Awaiting requested review from whsieh

Assignees

@megangardner megangardner

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@megangardner @webkit-early-warning-system @hortont424 @webkit-commit-queue