Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new flavor in thread_set_exception_ports #10216

Conversation

Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

mach_port_deallocate(mach_task_self(), thread);
});


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this extra bank line.

@MenloDorian MenloDorian added the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023
@AtariDreams
Copy link
Contributor

Build failed

https://bugs.webkit.org/show_bug.cgi?id=247635
rdar://101307915

Reviewed by Mark Lam.

Use EXCEPTION_IDENTITY_PROTECTED flavor in the mach exception handling

* Source/WTF/wtf/threads/Signals.cpp:

Canonical link: https://commits.webkit.org/260410@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebKit-mach-_set_exception-EXCEPTION_IDENTITY_PROTECTED-adoption branch from 682a1b1 to b9449c6 Compare February 17, 2023 01:53
@webkit-commit-queue webkit-commit-queue merged commit b9449c6 into WebKit:main Feb 17, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260410@main (b9449c6): https://commits.webkit.org/260410@main

Reviewed commits have been landed. Closing PR #10216 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants