Optimize TransformationMatrix inverse on ARM64 #10283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
WebCore Misc.
|
@cdumez - we have old bug and I posted here about this - https://bugs.webkit.org/show_bug.cgi?id=24996 |
|
EWS run on previous version of this PR (hash 29601c2) |
cdumez
force-pushed
the
252487_TransformMatrix_inverse
branch
from
29601c2
to
b88f551
Compare
|
EWS run on previous version of this PR (hash b88f551) |
Constellation
approved these changes
Feb 17, 2023
| @@ -216,12 +213,129 @@ static bool inverse(const TransformationMatrix::Matrix4& matrix, TransformationM | |||
| if (fabs(det) < SMALL_NUMBER) | |||
| return false; | |||
|
|
|||
| // Scale the adjoint matrix to get the inverse | |||
| #if CPU(ARM64) && defined(_LP64) | |||
There was a problem hiding this comment.
Let's use CPU(ARM64) && CPU(ADDRESS64)
cdumez
force-pushed
the
252487_TransformMatrix_inverse
branch
from
b88f551
to
19de229
Compare
|
EWS run on current version of this PR (hash 19de229)
|
webkit-early-warning-system
force-pushed
the
252487_TransformMatrix_inverse
branch
from
19de229
to
a8e2fd4
Compare
https://bugs.webkit.org/show_bug.cgi?id=252487 Reviewed by Yusuke Suzuki. Optimize TransformationMatrix inverse on ARM64 by using SIMD. This is a cherry-pick of: https://chromium.googlesource.com/chromium/blink/+/7b03a53c2c7f24fb1dd79c0e7f4b7fad520875a5 I benchmarked this locally on M1 Pro with 100k matrices of random double values. I saw a 20% speedup. * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::adjoint): (WebCore::inverse): Canonical link: https://commits.webkit.org/260468@main
webkit-early-warning-system
force-pushed
the
252487_TransformMatrix_inverse
branch
from
a8e2fd4
to
cf6d576
Compare
|
Committed 260468@main (cf6d576): https://commits.webkit.org/260468@main Reviewed commits have been landed. Closing PR #10283 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf6d576
19de229
🧪 api-gtk🧪 mac-AS-debug-wk2