-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGRESSION(260457@main): WKView is still needed #10369
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/REGRESSION260457main-WKView-is-still-needed
Feb 20, 2023
Merged
REGRESSION(260457@main): WKView is still needed #10369
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/REGRESSION260457main-WKView-is-still-needed
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
label
Feb 20, 2023
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 20, 2023
Commit message contains (OOPS!) and no reviewer found, blocking PR #10369 |
achristensen07
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 20, 2023
achristensen07
force-pushed
the
eng/REGRESSION260457main-WKView-is-still-needed
branch
from
February 20, 2023 17:28
a5ecb96
to
59a8424
Compare
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=252572 Unreviewed. It's still used for perf testing. This reverts the source changes. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm: * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm: * Source/WebKit/UIProcess/API/Cocoa/WKView.h: (WK_CLASS_DEPRECATED_WITH_REPLACEMENT): * Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h: Added. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h: * Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm: (-[_WKThumbnailView initWithFrame:fromWKView:]): (-[_WKThumbnailView _viewWasUnparented]): (-[_WKThumbnailView _viewWasParented]): * Source/WebKit/UIProcess/API/mac/WKView.mm: Added. (-[WKView initWithFrame:processGroup:browsingContextGroup:]): (-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]): (-[WKView dealloc]): (-[WKView browsingContextController]): (-[WKView setDrawsBackground:]): (-[WKView drawsBackground]): (-[WKView _backgroundColor]): (-[WKView _setBackgroundColor:]): (-[WKView setDrawsTransparentBackground:]): (-[WKView drawsTransparentBackground]): (-[WKView acceptsFirstResponder]): (-[WKView becomeFirstResponder]): (-[WKView resignFirstResponder]): (-[WKView viewWillStartLiveResize]): (-[WKView viewDidEndLiveResize]): (-[WKView isFlipped]): (-[WKView intrinsicContentSize]): (-[WKView prepareContentInRect:]): (-[WKView setFrameSize:]): (-[WKView _setSemanticContext:]): (-[WKView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WKView writeSelectionToPasteboard:types:]): (-[WKView centerSelectionInVisibleArea:]): (-[WKView validRequestorForSendType:returnType:]): (-[WKView readSelectionFromPasteboard:]): (-[WKView changeFont:]): (-[WKView validateUserInterfaceItem:]): (-[WKView startSpeaking:]): (-[WKView stopSpeaking:]): (-[WKView showGuessPanel:]): (-[WKView checkSpelling:]): (-[WKView changeSpelling:]): (-[WKView toggleContinuousSpellChecking:]): (-[WKView isGrammarCheckingEnabled]): (-[WKView setGrammarCheckingEnabled:]): (-[WKView toggleGrammarChecking:]): (-[WKView toggleAutomaticSpellingCorrection:]): (-[WKView orderFrontSubstitutionsPanel:]): (-[WKView toggleSmartInsertDelete:]): (-[WKView isAutomaticQuoteSubstitutionEnabled]): (-[WKView setAutomaticQuoteSubstitutionEnabled:]): (-[WKView toggleAutomaticQuoteSubstitution:]): (-[WKView isAutomaticDashSubstitutionEnabled]): (-[WKView setAutomaticDashSubstitutionEnabled:]): (-[WKView toggleAutomaticDashSubstitution:]): (-[WKView isAutomaticLinkDetectionEnabled]): (-[WKView setAutomaticLinkDetectionEnabled:]): (-[WKView toggleAutomaticLinkDetection:]): (-[WKView isAutomaticTextReplacementEnabled]): (-[WKView setAutomaticTextReplacementEnabled:]): (-[WKView toggleAutomaticTextReplacement:]): (-[WKView uppercaseWord:]): (-[WKView lowercaseWord:]): (-[WKView capitalizeWord:]): (-[WKView _wantsKeyDownForEvent:]): (-[WKView scrollWheel:]): (-[WKView swipeWithEvent:]): (-[WKView mouseDown:]): (-[WKView mouseUp:]): (-[WKView mouseDragged:]): (-[WKView otherMouseDown:]): (-[WKView otherMouseDragged:]): (-[WKView otherMouseUp:]): (-[WKView rightMouseDown:]): (-[WKView rightMouseDragged:]): (-[WKView rightMouseUp:]): (-[WKView pressureChangeWithEvent:]): (-[WKView acceptsFirstMouse:]): (-[WKView shouldDelayWindowOrderingForEvent:]): (-[WKView doCommandBySelector:]): (-[WKView insertText:]): (-[WKView insertText:replacementRange:]): (-[WKView inputContext]): (-[WKView performKeyEquivalent:]): (-[WKView keyUp:]): (-[WKView keyDown:]): (-[WKView flagsChanged:]): (-[WKView setMarkedText:selectedRange:replacementRange:]): (-[WKView unmarkText]): (-[WKView selectedRange]): (-[WKView hasMarkedText]): (-[WKView markedRange]): (-[WKView attributedSubstringForProposedRange:actualRange:]): (-[WKView characterIndexForPoint:]): (-[WKView firstRectForCharacterRange:actualRange:]): (-[WKView selectedRangeWithCompletionHandler:]): (-[WKView markedRangeWithCompletionHandler:]): (-[WKView hasMarkedTextWithCompletionHandler:]): (-[WKView attributedSubstringForProposedRange:completionHandler:]): (-[WKView firstRectForCharacterRange:completionHandler:]): (-[WKView characterIndexForPoint:completionHandler:]): (-[WKView validAttributesForMarkedText]): (-[WKView draggedImage:endedAt:operation:]): (-[WKView draggingEntered:]): (-[WKView draggingUpdated:]): (-[WKView draggingExited:]): (-[WKView prepareForDragOperation:]): (-[WKView performDragOperation:]): (-[WKView _hitTest:dragTypes:]): (-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]): (-[WKView viewWillMoveToWindow:]): (-[WKView viewDidMoveToWindow]): (-[WKView drawRect:]): (-[WKView isOpaque]): (-[WKView mouseDownCanMoveWindow]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]): (-[WKView viewDidChangeBackingProperties]): (-[WKView _activeSpaceDidChange:]): (-[WKView accessibilityFocusedUIElement]): (-[WKView accessibilityHitTest:]): (-[WKView accessibilityAttributeValue:]): (-[WKView accessibilityAttributeValue:forParameter:]): (-[WKView hitTest:]): (-[WKView conversationIdentifier]): (-[WKView quickLookWithEvent:]): (-[WKView addTrackingRect:owner:userData:assumeInside:]): (-[WKView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): (-[WKView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): (-[WKView removeTrackingRect:]): (-[WKView _removeTrackingRects:count:]): (-[WKView view:stringForToolTip:point:userData:]): (-[WKView pasteboardChangedOwner:]): (-[WKView pasteboard:provideDataForType:]): (-[WKView namesOfPromisedFilesDroppedAtDestination:]): (-[WKView maybeInstallIconLoadingClient]): (-[WKView initWithFrame:processPool:configuration:]): (-[WKView _setThumbnailView:]): (-[WKView _thumbnailView]): (-[WKView _web_superInputContext]): (-[WKView _web_superQuickLookWithEvent:]): (-[WKView _web_superSwipeWithEvent:]): (-[WKView _web_superMagnifyWithEvent:]): (-[WKView _web_superSmartMagnifyWithEvent:]): (-[WKView _web_superRemoveTrackingRect:]): (-[WKView _web_superAccessibilityAttributeValue:]): (-[WKView _web_superDoCommandBySelector:]): (-[WKView _web_superPerformKeyEquivalent:]): (-[WKView _web_superKeyDown:]): (-[WKView _web_superHitTest:]): (-[WKView _web_immediateActionAnimationControllerForHitTestResultInternal:withType:userData:]): (-[WKView _web_prepareForImmediateActionAnimation]): (-[WKView _web_cancelImmediateActionAnimation]): (-[WKView _web_completeImmediateActionAnimation]): (-[WKView _web_didChangeContentSize:]): (-[WKView _web_didPerformDragOperation:]): (-[WKView _web_dragDestinationActionForDraggingInfo:]): (-[WKView _web_dismissContentRelativeChildWindows]): (-[WKView _web_dismissContentRelativeChildWindowsWithAnimation:]): (-[WKView _web_editorStateDidChange]): (-[WKView _web_gestureEventWasNotHandledByWebCore:]): (-[WKView _didHandleAcceptedCandidate]): (-[WKView _didUpdateCandidateListVisibility:]): (-[WKView makeTouchBar]): (-[WKView candidateListTouchBarItem]): (-[WKView _web_didAddMediaControlsManager:]): (-[WKView _web_didRemoveMediaControlsManager]): (-[WKView scrollViewFrame]): (-[WKView hasScrolledContentsUnderTitlebar]): (-[WKView filePromiseProvider:fileNameForType:]): (-[WKView filePromiseProvider:writePromiseToURL:completionHandler:]): (-[WKView draggingSession:sourceOperationMaskForDraggingContext:]): (-[WKView draggingSession:endedAtPoint:operation:]): (-[WKView saveBackForwardSnapshotForCurrentItem]): (-[WKView saveBackForwardSnapshotForItem:]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (toUserInterfaceLayoutDirection): (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): (-[WKView initWithFrame:configurationRef:]): (-[WKView wantsUpdateLayer]): (-[WKView updateLayer]): (-[WKView pageRef]): (-[WKView canChangeFrameLayout:]): (-[WKView printOperationWithPrintInfo:forFrame:]): (-[WKView setFrame:andScrollBy:]): (-[WKView disableFrameSizeUpdates]): (-[WKView enableFrameSizeUpdates]): (-[WKView frameSizeUpdatesDisabled]): (+[WKView hideWordDefinitionWindow]): (-[WKView minimumSizeForAutoLayout]): (-[WKView setMinimumSizeForAutoLayout:]): (-[WKView sizeToContentAutoSizeMaximumSize]): (-[WKView setSizeToContentAutoSizeMaximumSize:]): (-[WKView shouldExpandToViewHeightForAutoLayout]): (-[WKView setShouldExpandToViewHeightForAutoLayout:]): (-[WKView shouldClipToVisibleRect]): (-[WKView setShouldClipToVisibleRect:]): (-[WKView underlayColor]): (-[WKView setUnderlayColor:]): (-[WKView _inspectorAttachmentView]): (-[WKView _setInspectorAttachmentView:]): (-[WKView fullScreenPlaceholderView]): (-[WKView createFullScreenWindow]): (-[WKView beginDeferringViewInWindowChanges]): (-[WKView endDeferringViewInWindowChanges]): (-[WKView endDeferringViewInWindowChangesSync]): (-[WKView _prepareForMoveToWindow:withCompletionHandler:]): (-[WKView isDeferringViewInWindowChanges]): (-[WKView windowOcclusionDetectionEnabled]): (-[WKView setWindowOcclusionDetectionEnabled:]): (-[WKView setAllowsBackForwardNavigationGestures:]): (-[WKView allowsBackForwardNavigationGestures]): (-[WKView allowsLinkPreview]): (-[WKView setAllowsLinkPreview:]): (-[WKView _setIgnoresAllEvents:]): (-[WKView _setIgnoresNonWheelMouseEvents:]): (-[WKView _setIgnoresNonWheelEvents:]): (-[WKView _ignoresNonWheelEvents]): (-[WKView _ignoresAllEvents]): (-[WKView _setOverrideDeviceScaleFactor:]): (-[WKView _overrideDeviceScaleFactor]): (-[WKView _layoutMode]): (-[WKView _setLayoutMode:]): (-[WKView _fixedLayoutSize]): (-[WKView _setFixedLayoutSize:]): (-[WKView _viewScale]): (-[WKView _setViewScale:]): (-[WKView _setTopContentInset:]): (-[WKView _topContentInset]): (-[WKView _setTotalHeightOfBanners:]): (-[WKView _totalHeightOfBanners]): (-[WKView _setOverlayScrollbarStyle:]): (-[WKView _overlayScrollbarStyle]): (-[WKView _pageExtendedBackgroundColor]): (-[WKView isUsingUISideCompositing]): (-[WKView setAllowsMagnification:]): (-[WKView allowsMagnification]): (-[WKView magnifyWithEvent:]): (-[WKView rotateWithEvent:]): (-[WKView _gestureEventWasNotHandledByWebCore:]): (-[WKView _simulateMouseMove:]): (-[WKView smartMagnifyWithEvent:]): (-[WKView setMagnification:centeredAtPoint:]): (-[WKView setMagnification:]): (-[WKView magnification]): (-[WKView _setCustomSwipeViews:]): (-[WKView _setCustomSwipeViewsTopContentInset:]): (-[WKView _tryToSwipeWithEvent:ignoringPinnedState:]): (-[WKView _setDidMoveSwipeSnapshotCallback:]): (-[WKView _immediateActionAnimationControllerForHitTestResult:withType:userData:]): (-[WKView _prepareForImmediateActionAnimation]): (-[WKView _cancelImmediateActionAnimation]): (-[WKView _completeImmediateActionAnimation]): (-[WKView _didChangeContentSize:]): (-[WKView _dismissContentRelativeChildWindows]): (-[WKView _dismissContentRelativeChildWindowsWithAnimation:]): (-[WKView _setAutomaticallyAdjustsContentInsets:]): (-[WKView _automaticallyAdjustsContentInsets]): (-[WKView setUserInterfaceLayoutDirection:]): (-[WKView _wantsMediaPlaybackControlsView]): (-[WKView _setWantsMediaPlaybackControlsView:]): (-[WKView _mediaPlaybackControlsView]): (-[WKView _addMediaPlaybackControlsView:]): (-[WKView _removeMediaPlaybackControlsView]): (-[WKView _doAfterNextPresentationUpdate:]): (-[WKView _setShouldSuppressFirstResponderChanges:]): (-[WKView viewDidChangeEffectiveAppearance]): (-[WKView _setUseSystemAppearance:]): (-[WKView _useSystemAppearance]): (-[WKView acceptsPreviewPanelControl:]): (-[WKView beginPreviewPanelControl:]): (-[WKView endPreviewPanelControl:]): * Source/WebKit/UIProcess/API/mac/WKViewInternal.h: Copied from Source/WebKit/UIProcess/API/Cocoa/WKView.h. * Source/WebKit/UIProcess/Gamepad/mac/UIGamepadProviderMac.mm: (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): * Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm: * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: * Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h: * Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm: * Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/260541@main
webkit-early-warning-system
force-pushed
the
eng/REGRESSION260457main-WKView-is-still-needed
branch
from
February 20, 2023 17:32
59a8424
to
ae2abef
Compare
Committed 260541@main (ae2abef): https://commits.webkit.org/260541@main Reviewed commits have been landed. Closing PR #10369 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 20, 2023
EWS run on current version of this PR (hash 59a8424)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ae2abef
59a8424
π§ͺ styleπ macπ wpeπ wincairoπ ios-simπ mac-AS-debugπ gtkπ§ͺ webkitperlπ§ͺ ios-wk2π§ͺ api-macπ§ͺ gtk-wk2π§ͺ api-iosπ§ͺ mac-wk1π§ͺ api-gtkπ tvπ§ͺ mac-wk2π tv-simπ§ͺ mac-AS-debug-wk2π watchπ§ͺ mac-wk2-stress