Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SigillCrashAnalyzer. #10373

Merged

Conversation

MenloDorian
Copy link

@MenloDorian MenloDorian commented Feb 20, 2023

5e7a6ef

Remove SigillCrashAnalyzer.
https://bugs.webkit.org/show_bug.cgi?id=252584
rdar://105687040

Reviewed by Yusuke Suzuki and Justin Michaud.

This was added a debugging aid once upon a time.  It is no longer needed.

* Source/JavaScriptCore/API/JSVirtualMachine.mm:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/InitializeThreading.cpp:
(JSC::initialize):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::isAvailable):
(JSC::overrideDefaults):
(JSC::disableAllJITOptions):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp: Removed.
* Source/JavaScriptCore/tools/SigillCrashAnalyzer.h: Removed.
* Source/WTF/wtf/PlatformEnableCocoa.h:

Canonical link: https://commits.webkit.org/260568@main

3e135b4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2   πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@MenloDorian MenloDorian requested a review from a team as a code owner February 20, 2023 19:17
@MenloDorian MenloDorian self-assigned this Feb 20, 2023
@MenloDorian MenloDorian added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 20, 2023
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the merge-queue Applied to send a pull request to merge-queue label Feb 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=252584
rdar://105687040

Reviewed by Yusuke Suzuki and Justin Michaud.

This was added a debugging aid once upon a time.  It is no longer needed.

* Source/JavaScriptCore/API/JSVirtualMachine.mm:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/InitializeThreading.cpp:
(JSC::initialize):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::isAvailable):
(JSC::overrideDefaults):
(JSC::disableAllJITOptions):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp: Removed.
* Source/JavaScriptCore/tools/SigillCrashAnalyzer.h: Removed.
* Source/WTF/wtf/PlatformEnableCocoa.h:

Canonical link: https://commits.webkit.org/260568@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260568@main (5e7a6ef): https://commits.webkit.org/260568@main

Reviewed commits have been landed. Closing PR #10373 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5e7a6ef into WebKit:main Feb 20, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 20, 2023
@MenloDorian MenloDorian deleted the eng/Remove-SigillCrashAnalyzer- branch February 20, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
5 participants