-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SigillCrashAnalyzer. #10373
Remove SigillCrashAnalyzer. #10373
Conversation
EWS run on current version of this PR (hash 3e135b4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=252584 rdar://105687040 Reviewed by Yusuke Suzuki and Justin Michaud. This was added a debugging aid once upon a time. It is no longer needed. * Source/JavaScriptCore/API/JSVirtualMachine.mm: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::isAvailable): (JSC::overrideDefaults): (JSC::disableAllJITOptions): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp: Removed. * Source/JavaScriptCore/tools/SigillCrashAnalyzer.h: Removed. * Source/WTF/wtf/PlatformEnableCocoa.h: Canonical link: https://commits.webkit.org/260568@main
3e135b4
to
5e7a6ef
Compare
Committed 260568@main (5e7a6ef): https://commits.webkit.org/260568@main Reviewed commits have been landed. Closing PR #10373 and removing active labels. |
5e7a6ef
3e135b4
π§ͺ ios-wk2π§ͺ gtk-wk2π§ͺ api-iosπ§ͺ api-gtkπ jsc-armv7π§ͺ jsc-armv7-tests