Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dump-as-markup.js in editing/selection/4983858.html #10402

Merged
merged 1 commit into from Feb 21, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Feb 20, 2023

84603a0

Use dump-as-markup.js in editing/selection/4983858.html
https://bugs.webkit.org/show_bug.cgi?id=252615

Reviewed by Wenson Hsieh.

Use dump-as-markup.js for clarity.

* LayoutTests/editing/selection/4983858-expected.txt: Added.
* LayoutTests/editing/selection/4983858.html:
* LayoutTests/platform/gtk/editing/selection/4983858-expected.png: Removed.
* LayoutTests/platform/gtk/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/ios/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/mac/editing/selection/4983858-expected.png: Removed.
* LayoutTests/platform/mac/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/wincairo/editing/selection/4983858-expected.txt: Removed.

Canonical link: https://commits.webkit.org/260596@main

f8c21ef

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac ❌ πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@rniwa rniwa self-assigned this Feb 20, 2023
@rniwa rniwa added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 20, 2023
@rniwa rniwa requested a review from whsieh February 20, 2023 22:51
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2023
https://bugs.webkit.org/show_bug.cgi?id=252615

Reviewed by Wenson Hsieh.

Use dump-as-markup.js for clarity.

* LayoutTests/editing/selection/4983858-expected.txt: Added.
* LayoutTests/editing/selection/4983858.html:
* LayoutTests/platform/gtk/editing/selection/4983858-expected.png: Removed.
* LayoutTests/platform/gtk/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/ios/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/mac/editing/selection/4983858-expected.png: Removed.
* LayoutTests/platform/mac/editing/selection/4983858-expected.txt: Removed.
* LayoutTests/platform/wincairo/editing/selection/4983858-expected.txt: Removed.

Canonical link: https://commits.webkit.org/260596@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260596@main (84603a0): https://commits.webkit.org/260596@main

Reviewed commits have been landed. Closing PR #10402 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2023
@rniwa rniwa deleted the fix252615 branch February 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants