Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Use BinarySwitch on new BBQ BrTable #10436

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[JSC] Use BinarySwitch on new BBQ BrTable #10436

merged 1 commit into from
Feb 21, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Feb 21, 2023 •
edited by webkit-early-warning-system

400b0a9

[JSC] Use BinarySwitch on new BBQ BrTable
https://bugs.webkit.org/show_bug.cgi?id=252655
rdar://105716386

Reviewed by Tadeu Zagallo.

As the same to Air BBQ IR generator, let's use BinarySwitch to efficiently jump to the large BrTable.
This improves tsf-wasm performance (only with new BBQ) from 0.845 to 2.904.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::ControlData::addBranch):
(JSC::Wasm::BBQJIT::addSwitch):

Canonical link: https://commits.webkit.org/260614@main

22ff45e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@Constellation Constellation requested a review from a team as a code owner February 21, 2023 08:47
@Constellation Constellation self-assigned this Feb 21, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash e6b4690)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac   🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings   🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🛠 gtk
  🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 gtk-wk2
⏳ 🧪 webkitpy   🧪 api-ios ⏳ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-wk2-stress ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@Constellation Constellation force-pushed the eng/JSC-Use-BinarySwitch-on-new-BBQ-BrTable branch from e6b4690 to 22ff45e Compare February 21, 2023 08:48
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 22ff45e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

tadeuzagallo
tadeuzagallo approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@tadeuzagallo tadeuzagallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2023
@Constellation
[JSC] Use BinarySwitch on new BBQ BrTable
400b0a9 
https://bugs.webkit.org/show_bug.cgi?id=252655
rdar://105716386

Reviewed by Tadeu Zagallo.

As the same to Air BBQ IR generator, let's use BinarySwitch to efficiently jump to the large BrTable.
This improves tsf-wasm performance (only with new BBQ) from 0.845 to 2.904.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::ControlData::addBranch):
(JSC::Wasm::BBQJIT::addSwitch):

Canonical link: https://commits.webkit.org/260614@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Use-BinarySwitch-on-new-BBQ-BrTable branch from 22ff45e to 400b0a9 Compare February 21, 2023 17:21
@webkit-commit-queue webkit-commit-queue merged commit 400b0a9 into WebKit:main Feb 21, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260614@main (400b0a9): https://commits.webkit.org/260614@main

Reviewed commits have been landed. Closing PR #10436 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 21, 2023
@Constellation Constellation deleted the eng/JSC-Use-BinarySwitch-on-new-BBQ-BrTable branch February 21, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo