Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose subclasses of serialized abstract classes to IPC test API as a std::variant #10467

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Expose subclasses of serialized abstract classes to IPC test API as a std::variant #10467

merged 1 commit into from
Feb 23, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Feb 21, 2023 •
edited by webkit-early-warning-system

09e9d1b

Expose subclasses of serialized abstract classes to IPC test API as a std::variant
https://bugs.webkit.org/show_bug.cgi?id=252690
rdar://105743470

Reviewed by Geoffrey Garen.

IPC sees the two identically.  Also reduce the size of the variant index to 1 byte and assert that that is enough.

* Source/WebKit/Platform/IPC/ArgumentCoders.h:
* Source/WebKit/Scripts/generate-serializers.py:
(generate_impl):
(generate_serialized_type_info):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(WTF::void>):
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
(WebKit::allSerializedTypes):

Canonical link: https://commits.webkit.org/260710@main

bf7b218

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@achristensen07 achristensen07 self-assigned this Feb 21, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Feb 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash c5c3563)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ⏳ 🛠 ios-sim ❌ 🛠 mac-AS-debug ⏳ 🛠 gtk
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 gtk-wk2
✅ 🧪 webkitpy ⏳ 🧪 api-ios ⏳ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ✅ 🛠 tv ⏳ 🧪 mac-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-wk2-stress ⏳ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@achristensen07 achristensen07 force-pushed the eng/Expose-subclasses-of-serialized-abstract-classes-to-IPC-test-API-as-a-stdvariant branch from c5c3563 to bf7b218 Compare February 21, 2023 23:04
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash bf7b218)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

geoffreygaren
geoffreygaren approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 23, 2023
@achristensen07
Expose subclasses of serialized abstract classes to IPC test API as a…
09e9d1b 
… std::variant

https://bugs.webkit.org/show_bug.cgi?id=252690
rdar://105743470

Reviewed by Geoffrey Garen.

IPC sees the two identically.  Also reduce the size of the variant index to 1 byte and assert that that is enough.

* Source/WebKit/Platform/IPC/ArgumentCoders.h:
* Source/WebKit/Scripts/generate-serializers.py:
(generate_impl):
(generate_serialized_type_info):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(WTF::void>):
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
(WebKit::allSerializedTypes):

Canonical link: https://commits.webkit.org/260710@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Expose-subclasses-of-serialized-abstract-classes-to-IPC-test-API-as-a-stdvariant branch from bf7b218 to 09e9d1b Compare February 23, 2023 00:33
@webkit-early-warning-system webkit-early-warning-system merged commit 09e9d1b into WebKit:main Feb 23, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260710@main (09e9d1b): https://commits.webkit.org/260710@main

Reviewed commits have been landed. Closing PR #10467 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@achristensen07 achristensen07

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @geoffreygaren