Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win] The generic URL::fileSystemPath has to remove a leading slash #10492

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Feb 22, 2023

5e1c8e0

[Win] The generic URL::fileSystemPath has to remove a leading slash
https://bugs.webkit.org/show_bug.cgi?id=252367

Reviewed by Darin Adler and Ross Kirsling.

Switched Windows port to use the generic URL::fileSystemPath rather
than one using CF.

URL::fileSystemPath has to remove a leading slash for Windows.
Otherwise it returns a path "/C:/x.txt" for a URL
"file:///C:/x.txt".

* Source/WTF/wtf/URL.cpp:
(WTF::URL::fileSystemPath const):
* Source/WTF/wtf/cf/URLCF.cpp:
(WTF::URL::fileSystemPath const):

Canonical link: https://commits.webkit.org/260739@main

5eba3aa

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim ⏳ πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@fujii fujii self-assigned this Feb 22, 2023
Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Source/WTF/wtf/cf/URLCF.cpp Outdated Show resolved Hide resolved
@fujii fujii force-pushed the eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash branch from dd9f886 to 5eba3aa Compare February 22, 2023 04:18
@fujii fujii added the merge-queue Applied to send a pull request to merge-queue label Feb 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=252367

Reviewed by Darin Adler and Ross Kirsling.

Switched Windows port to use the generic URL::fileSystemPath rather
than one using CF.

URL::fileSystemPath has to remove a leading slash for Windows.
Otherwise it returns a path "/C:/x.txt" for a URL
"file:///C:/x.txt".

* Source/WTF/wtf/URL.cpp:
(WTF::URL::fileSystemPath const):
* Source/WTF/wtf/cf/URLCF.cpp:
(WTF::URL::fileSystemPath const):

Canonical link: https://commits.webkit.org/260739@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash branch from 5eba3aa to 5e1c8e0 Compare February 23, 2023 11:39
@webkit-commit-queue
Copy link
Collaborator

Committed 260739@main (5e1c8e0): https://commits.webkit.org/260739@main

Reviewed commits have been landed. Closing PR #10492 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 5e1c8e0 into WebKit:main Feb 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 23, 2023
@fujii fujii deleted the eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash branch June 30, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants