New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Win] The generic URL::fileSystemPath has to remove a leading slash #10492
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
fujii:eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash
Feb 23, 2023
Merged
[Win] The generic URL::fileSystemPath has to remove a leading slash #10492
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
fujii:eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash dd9f886) |
rkirsling
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
fujii
force-pushed
the
eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash
branch
from
February 22, 2023 04:18
dd9f886
to
5eba3aa
Compare
EWS run on current version of this PR (hash 5eba3aa) |
darinadler
approved these changes
Feb 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=252367 Reviewed by Darin Adler and Ross Kirsling. Switched Windows port to use the generic URL::fileSystemPath rather than one using CF. URL::fileSystemPath has to remove a leading slash for Windows. Otherwise it returns a path "/C:/x.txt" for a URL "file:///C:/x.txt". * Source/WTF/wtf/URL.cpp: (WTF::URL::fileSystemPath const): * Source/WTF/wtf/cf/URLCF.cpp: (WTF::URL::fileSystemPath const): Canonical link: https://commits.webkit.org/260739@main
webkit-early-warning-system
force-pushed
the
eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash
branch
from
February 23, 2023 11:39
5eba3aa
to
5e1c8e0
Compare
Committed 260739@main (5e1c8e0): https://commits.webkit.org/260739@main Reviewed commits have been landed. Closing PR #10492 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Feb 23, 2023
fujii
deleted the
eng/Win-The-generic-URLfileSystemPath-has-to-remove-a-leading-slash
branch
June 30, 2023 03:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5e1c8e0
5eba3aa