Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bounds issues in API tests #10543

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Feb 22, 2023

d5d4ade

Fix some bounds issues in API tests
https://bugs.webkit.org/show_bug.cgi?id=252779
rdar://105784168

Reviewed by Darin Adler.

Asan found some out of bounds operations because of how we wrote our tests.

* Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp:
(TestWebKitAPI::testFixedBitVectorFindBit):
* Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):

Canonical link: https://commits.webkit.org/260746@main

a72f09b

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@achristensen07 achristensen07 self-assigned this Feb 22, 2023
@achristensen07 achristensen07 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 22, 2023
@achristensen07 achristensen07 force-pushed the eng/Fix-some-bounds-issues-in-API-tests branch from 1cd788f to a72f09b Compare February 23, 2023 00:35
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=252779
rdar://105784168

Reviewed by Darin Adler.

Asan found some out of bounds operations because of how we wrote our tests.

* Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp:
(TestWebKitAPI::testFixedBitVectorFindBit):
* Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
* Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):

Canonical link: https://commits.webkit.org/260746@main
@webkit-early-warning-system webkit-early-warning-system merged commit d5d4ade into WebKit:main Feb 23, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260746@main (d5d4ade): https://commits.webkit.org/260746@main

Reviewed commits have been landed. Closing PR #10543 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants