Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebKitSetIsClassic check #10581

Merged

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Feb 23, 2023

Copy link
Contributor

@achristensen07 achristensen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this after having searched internally. However, cleanups like this in WebKitLegacy are likely wasted effort.

@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Feb 25, 2023
https://bugs.webkit.org/show_bug.cgi?id=252822

Reviewed by Alex Christensen.

This function is no longer being called, so we can remove it.

*Source\WebKitLegacy\ios\Misc\WebUIKitSupport.h:
*Source\WebKitLegacy\ios\Misc\WebUIKitSupport.mm:
*Source\WebKitLegacy\ios\WebKit.iOS.exp:

Canonical link: https://commits.webkit.org/260832@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260832@main (85c350c): https://commits.webkit.org/260832@main

Reviewed commits have been landed. Closing PR #10581 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 85c350c into WebKit:main Feb 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 25, 2023
@AtariDreams AtariDreams deleted the eng/Remove-WebKitSetIsClassic branch February 25, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants