WebProcessPool::processForNavigation() should prevent the process from getting shut down while waiting for AddAllowedFirstPartyForCookies IPC reply #10603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
approved these changes
Feb 23, 2023
|
EWS run on current version of this PR (hash 10276e7)
|
…m getting shut down while waiting for AddAllowedFirstPartyForCookies IPC reply https://bugs.webkit.org/show_bug.cgi?id=252843 rdar://105375981 Reviewed by Alex Christensen. ebProcessPool::processForNavigation() should prevent the process from getting shut down (or added to the process cache) while waiting for AddAllowedFirstPartyForCookies IPC reply. We recently fixed the lambda in WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation() but failed to fix this one. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): Canonical link: https://commits.webkit.org/260754@main
webkit-early-warning-system
force-pushed
the
252843_processForNavigation_preventShutdown
branch
from
10276e7
to
9e54e08
Compare
|
Committed 260754@main (9e54e08): https://commits.webkit.org/260754@main Reviewed commits have been landed. Closing PR #10603 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9e54e08
10276e7
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🛠 gtk🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress