Prefer std::abs over fabs #10699

AtariDreams · 2023-02-26T20:59:38Z

`da93445`

Prefer std::abs over fabs
https://bugs.webkit.org/show_bug.cgi?id=252974

Reviewed by Ryosuke Niwa.

Unlike the C library versions, std::abs has overloads for every type, so one does not need to worry about which version of the function to call.

* Source/JavaScriptCore/assembler/MacroAssembler.h:
* Source/JavaScriptCore/b3/B3ConstDoubleValue.cpp:
* Source/JavaScriptCore/b3/B3ConstFloatValue.cpp:
* Source/JavaScriptCore/b3/testb3_3.cpp:
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
* Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h:
* Source/JavaScriptCore/runtime/DateConversion.cpp:
* Source/JavaScriptCore/runtime/ISO8601.cpp:
* Source/JavaScriptCore/runtime/MathCommon.cpp:
* Source/JavaScriptCore/runtime/MathObject.cpp:
* Source/JavaScriptCore/runtime/NumberPrototype.cpp:
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
* Source/WTF/wtf/CurrentTime.cpp:
* Source/WTF/wtf/DateMath.cpp:
* Source/WTF/wtf/MediaTime.cpp:
* Source/WTF/wtf/text/TextStream.cpp:
* Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp:
* Source/WebCore/Modules/webaudio/AudioParam.cpp:
* Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:
* Source/WebCore/Modules/webaudio/IIRFilterNode.cpp:
* Source/WebCore/Modules/webaudio/OscillatorNode.cpp:
* Source/WebCore/Modules/webaudio/PeriodicWave.cpp:
* Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
* Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp:
* Source/WebCore/contentextensions/DFABytecodeCompiler.cpp:
* Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp:
* Source/WebCore/editing/FrameSelection.cpp:
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
* Source/WebCore/html/CustomPaintImage.cpp:
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/inspector/InspectorOverlay.cpp:
* Source/WebCore/layout/Verification.cpp:
* Source/WebCore/page/EventHandler.cpp:
* Source/WebCore/page/Frame.cpp:
* Source/WebCore/page/WheelEventDeltaFilter.cpp:
* Source/WebCore/page/ios/FrameIOS.mm:
* Source/WebCore/platform/LayoutUnit.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
* Source/WebCore/platform/ScrollAnimationKeyboard.cpp:
* Source/WebCore/platform/ScrollAnimationKinetic.cpp:
* Source/WebCore/platform/ScrollView.cpp:
* Source/WebCore/platform/audio/Biquad.cpp:
* Source/WebCore/platform/audio/Cone.cpp:
* Source/WebCore/platform/audio/DenormalDisabler.h:
* Source/WebCore/platform/audio/FFTFrame.cpp:
* Source/WebCore/platform/audio/HRTFPanner.cpp:
* Source/WebCore/platform/audio/IIRFilter.cpp:
* Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm:
* Source/WebCore/platform/graphics/FloatLine.cpp:
* Source/WebCore/platform/graphics/FloatSize.cpp:
* Source/WebCore/platform/graphics/GradientImage.cpp:
* Source/WebCore/platform/graphics/IntSize.h:
* Source/WebCore/platform/graphics/PathUtilities.cpp:
* Source/WebCore/platform/graphics/ShadowBlur.cpp:
* Source/WebCore/platform/graphics/UnitBezier.h:
* Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:
* Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:
* Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
* Source/WebCore/platform/graphics/win/FontCacheWin.cpp:
* Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
* Source/WebCore/platform/graphics/win/SystemFontDatabaseWin.cpp:
* Source/WebCore/platform/ios/ScrollAnimatorIOS.mm:
* Source/WebCore/platform/ios/WebAVPlayerController.mm:
* Source/WebCore/platform/ios/wak/WKView.mm:
* Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm:
* Source/WebCore/platform/mac/ScrollingEffectsController.mm:
* Source/WebCore/platform/win/BitmapInfo.h:
* Source/WebCore/platform/win/PopupMenuWin.cpp:
* Source/WebCore/platform/xr/openxr/OpenXRUtils.h:
* Source/WebCore/rendering/AttachmentLayout.mm:
* Source/WebCore/rendering/BorderPainter.cpp:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderListBox.cpp:
* Source/WebCore/rendering/RenderMarquee.cpp:
* Source/WebCore/rendering/shapes/RasterShape.cpp:
* Source/WebCore/rendering/svg/SVGMarkerData.h:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
* Source/WebCore/svg/SVGPathParser.cpp:
* Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
* Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp:
* Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:
* Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:
* Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
* Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm:
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm:
* Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
* Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

Canonical link: https://commits.webkit.org/261584@main

9982a47

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🛠 jsc-mips
			✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-26T21:01:38Z

EWS run on previous version of this PR (hash ca91a4c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	❌ 🛠 wincairo
~~🧪 bindings~~	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🛠 gtk~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	~~🛠 tv~~	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	~~🛠 tv-sim~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	~~🛠 watch~~	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-mips
	~~🛠 watch-sim~~		~~🧪 jsc-mips-tests~~

rniwa · 2023-02-26T21:02:34Z

Please use Tools/Scripts/git-WebKit upload to create a PR after running Tools/Scripts/git-WebKit setup.

Your commit message must follow a certain format.

rniwa

Commit message is in wrong format.

AtariDreams · 2023-02-26T21:11:08Z

Commit message is in wrong format.

Will address.

webkit-early-warning-system · 2023-02-26T21:14:00Z

EWS run on previous version of this PR (hash 4463f92)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🛠 gtk~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
~~🛠 🧪 jsc~~	⏳ 🛠 tv	~~🧪 mac-wk2~~	⏳ 🛠 jsc-armv7
~~🛠 🧪 jsc-arm64~~	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	~~🧪 mac-wk2-stress~~	~~🛠 jsc-mips~~
	⏳ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-02-26T21:23:25Z

EWS run on previous version of this PR (hash f8bb1e1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	❌ 🛠 wpe	⏳ 🛠 wincairo
⏳ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	❌ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	~~🛠 tv~~	~~🧪 mac-wk2~~	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-02-26T21:42:49Z

EWS run on previous version of this PR (hash 8d58a46)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-27T00:41:37Z

EWS run on previous version of this PR (hash 6236140)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-27T04:05:12Z

EWS run on previous version of this PR (hash 5cd7689)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	~~🛠 tv~~	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-mips
	~~🛠 watch-sim~~		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-02-27T04:12:02Z

EWS run on previous version of this PR (hash 89d6f82)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-27T21:47:10Z

EWS run on previous version of this PR (hash 88de8d6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

rniwa · 2023-02-28T07:53:52Z

Yes, I know fabs is not the only one with this issue, but if I made the changes for all std::math methods this PR would be too big and it is big enough as is.

This comment doesn't seem to add any value. Please remove it.

Source/JavaScriptCore/assembler/MacroAssembler.h:

There needs to be a list of each file being modified along with the list of functions being modified.

webkit-early-warning-system · 2023-02-28T15:41:13Z

EWS run on previous version of this PR (hash fa5230e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

rniwa

The commit message needs to have a full list of files and functions like other commits.

webkit-early-warning-system · 2023-02-28T18:59:07Z

EWS run on previous version of this PR (hash 51ac7ac)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

AtariDreams · 2023-02-28T19:00:37Z

Done!

webkit-early-warning-system · 2023-02-28T20:49:20Z

EWS run on previous version of this PR (hash 3e50b1d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🛠 gtk~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

AtariDreams · 2023-02-28T20:50:19Z

All ready!

webkit-early-warning-system · 2023-02-28T21:04:54Z

EWS run on previous version of this PR (hash 17bdedb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim		✅ 🛠 jsc-mips
			✅ 🧪 jsc-mips-tests

Source/JavaScriptCore/b3/testb3_3.cpp

rniwa

r=me

AtariDreams · 2023-03-13T16:28:46Z

Can we merge this please?

webkit-early-warning-system · 2023-03-13T16:35:11Z

EWS run on current version of this PR (hash 9982a47)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🛠 jsc-mips
			✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=252974 Reviewed by Ryosuke Niwa. Unlike the C library versions, std::abs has overloads for every type, so one does not need to worry about which version of the function to call. * Source/JavaScriptCore/assembler/MacroAssembler.h: * Source/JavaScriptCore/b3/B3ConstDoubleValue.cpp: * Source/JavaScriptCore/b3/B3ConstFloatValue.cpp: * Source/JavaScriptCore/b3/testb3_3.cpp: * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: * Source/JavaScriptCore/dfg/DFGOperations.cpp: * Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h: * Source/JavaScriptCore/runtime/DateConversion.cpp: * Source/JavaScriptCore/runtime/ISO8601.cpp: * Source/JavaScriptCore/runtime/MathCommon.cpp: * Source/JavaScriptCore/runtime/MathObject.cpp: * Source/JavaScriptCore/runtime/NumberPrototype.cpp: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: * Source/WTF/wtf/CurrentTime.cpp: * Source/WTF/wtf/DateMath.cpp: * Source/WTF/wtf/MediaTime.cpp: * Source/WTF/wtf/text/TextStream.cpp: * Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp: * Source/WebCore/Modules/webaudio/AudioParam.cpp: * Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp: * Source/WebCore/Modules/webaudio/IIRFilterNode.cpp: * Source/WebCore/Modules/webaudio/OscillatorNode.cpp: * Source/WebCore/Modules/webaudio/PeriodicWave.cpp: * Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: * Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp: * Source/WebCore/contentextensions/DFABytecodeCompiler.cpp: * Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp: * Source/WebCore/editing/FrameSelection.cpp: * Source/WebCore/editing/cocoa/HTMLConverter.mm: * Source/WebCore/html/CustomPaintImage.cpp: * Source/WebCore/html/HTMLMediaElement.cpp: * Source/WebCore/inspector/InspectorOverlay.cpp: * Source/WebCore/layout/Verification.cpp: * Source/WebCore/page/EventHandler.cpp: * Source/WebCore/page/Frame.cpp: * Source/WebCore/page/WheelEventDeltaFilter.cpp: * Source/WebCore/page/ios/FrameIOS.mm: * Source/WebCore/platform/LayoutUnit.h: * Source/WebCore/platform/LocalizedStrings.cpp: * Source/WebCore/platform/ScrollAnimationKeyboard.cpp: * Source/WebCore/platform/ScrollAnimationKinetic.cpp: * Source/WebCore/platform/ScrollView.cpp: * Source/WebCore/platform/audio/Biquad.cpp: * Source/WebCore/platform/audio/Cone.cpp: * Source/WebCore/platform/audio/DenormalDisabler.h: * Source/WebCore/platform/audio/FFTFrame.cpp: * Source/WebCore/platform/audio/HRTFPanner.cpp: * Source/WebCore/platform/audio/IIRFilter.cpp: * Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm: * Source/WebCore/platform/graphics/FloatLine.cpp: * Source/WebCore/platform/graphics/FloatSize.cpp: * Source/WebCore/platform/graphics/GradientImage.cpp: * Source/WebCore/platform/graphics/IntSize.h: * Source/WebCore/platform/graphics/PathUtilities.cpp: * Source/WebCore/platform/graphics/ShadowBlur.cpp: * Source/WebCore/platform/graphics/UnitBezier.h: * Source/WebCore/platform/graphics/cairo/CairoOperations.cpp: * Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp: * Source/WebCore/platform/graphics/transforms/AffineTransform.cpp: * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: * Source/WebCore/platform/graphics/win/FontCacheWin.cpp: * Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp: * Source/WebCore/platform/graphics/win/SystemFontDatabaseWin.cpp: * Source/WebCore/platform/ios/ScrollAnimatorIOS.mm: * Source/WebCore/platform/ios/WebAVPlayerController.mm: * Source/WebCore/platform/ios/wak/WKView.mm: * Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm: * Source/WebCore/platform/mac/ScrollingEffectsController.mm: * Source/WebCore/platform/win/BitmapInfo.h: * Source/WebCore/platform/win/PopupMenuWin.cpp: * Source/WebCore/platform/xr/openxr/OpenXRUtils.h: * Source/WebCore/rendering/AttachmentLayout.mm: * Source/WebCore/rendering/BorderPainter.cpp: * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: * Source/WebCore/rendering/RenderListBox.cpp: * Source/WebCore/rendering/RenderMarquee.cpp: * Source/WebCore/rendering/shapes/RasterShape.cpp: * Source/WebCore/rendering/svg/SVGMarkerData.h: * Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp: * Source/WebCore/style/StyleBuilderConverter.h: * Source/WebCore/style/StyleFontSizeFunctions.cpp: * Source/WebCore/svg/SVGPathParser.cpp: * Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: * Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp: * Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp: * Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm: * Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: * Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm: * Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm: * Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: * Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Canonical link: https://commits.webkit.org/261584@main

webkit-commit-queue · 2023-03-13T20:06:24Z

Committed 261584@main (da93445): https://commits.webkit.org/261584@main

Reviewed commits have been landed. Closing PR #10699 and removing active labels.

AtariDreams requested review from a team, magomez, zdobersek, cdumez, rniwa, patrickangle and JonWBedard as code owners February 26, 2023 20:59

rniwa requested changes Feb 26, 2023

View reviewed changes

AtariDreams force-pushed the double branch from ca91a4c to 4463f92 Compare February 26, 2023 21:10

AtariDreams marked this pull request as draft February 26, 2023 21:11

AtariDreams force-pushed the double branch from 4463f92 to f8bb1e1 Compare February 26, 2023 21:13

AtariDreams force-pushed the double branch from f8bb1e1 to 8d58a46 Compare February 26, 2023 21:39

AtariDreams force-pushed the double branch from 8d58a46 to 6236140 Compare February 27, 2023 00:40

AtariDreams marked this pull request as ready for review February 27, 2023 00:41

AtariDreams force-pushed the double branch from 6236140 to 5cd7689 Compare February 27, 2023 04:04

AtariDreams force-pushed the double branch from 5cd7689 to 89d6f82 Compare February 27, 2023 04:11

AtariDreams force-pushed the double branch from 89d6f82 to 88de8d6 Compare February 27, 2023 21:47

AtariDreams removed the request for review from zdobersek February 28, 2023 15:40

AtariDreams requested review from rniwa and removed request for JonWBedard and patrickangle February 28, 2023 15:40

AtariDreams force-pushed the double branch from 88de8d6 to fa5230e Compare February 28, 2023 15:41

rniwa requested changes Feb 28, 2023

View reviewed changes

AtariDreams force-pushed the double branch from fa5230e to 51ac7ac Compare February 28, 2023 18:58

AtariDreams requested a review from rniwa February 28, 2023 18:59

AtariDreams force-pushed the double branch from 51ac7ac to 3e50b1d Compare February 28, 2023 20:48

AtariDreams force-pushed the double branch from 3e50b1d to 17bdedb Compare February 28, 2023 21:04

rniwa reviewed Feb 28, 2023

View reviewed changes

Source/JavaScriptCore/b3/testb3_3.cpp Show resolved Hide resolved

rniwa approved these changes Feb 28, 2023

View reviewed changes

Ahmad-S792 assigned AtariDreams Mar 1, 2023

Ahmad-S792 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 1, 2023

AtariDreams force-pushed the double branch from 17bdedb to 9982a47 Compare March 13, 2023 16:33

rniwa approved these changes Mar 13, 2023

View reviewed changes

rniwa added the merge-queue Applied to send a pull request to merge-queue label Mar 13, 2023

webkit-commit-queue force-pushed the double branch from 9982a47 to da93445 Compare March 13, 2023 20:06

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 13, 2023

webkit-commit-queue merged commit da93445 into WebKit:main Mar 13, 2023

AtariDreams deleted the double branch March 13, 2023 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prefer std::abs over fabs #10699

Prefer std::abs over fabs #10699

AtariDreams commented Feb 26, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 26, 2023 •

edited

rniwa commented Feb 26, 2023

rniwa left a comment

AtariDreams commented Feb 26, 2023

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

rniwa commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

rniwa left a comment

webkit-early-warning-system commented Feb 28, 2023 •

edited

AtariDreams commented Feb 28, 2023

webkit-early-warning-system commented Feb 28, 2023 •

edited

AtariDreams commented Feb 28, 2023

webkit-early-warning-system commented Feb 28, 2023 •

edited

rniwa left a comment

AtariDreams commented Mar 13, 2023

webkit-early-warning-system commented Mar 13, 2023 •

edited

webkit-commit-queue commented Mar 13, 2023

Prefer std::abs over fabs #10699

Prefer std::abs over fabs #10699

Conversation

AtariDreams commented Feb 26, 2023 • edited by webkit-early-warning-system

da93445

webkit-early-warning-system commented Feb 26, 2023 • edited

rniwa commented Feb 26, 2023

rniwa left a comment

Choose a reason for hiding this comment

AtariDreams commented Feb 26, 2023

webkit-early-warning-system commented Feb 26, 2023 • edited

webkit-early-warning-system commented Feb 26, 2023 • edited

webkit-early-warning-system commented Feb 26, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

rniwa commented Feb 28, 2023 • edited

webkit-early-warning-system commented Feb 28, 2023 • edited

rniwa left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 28, 2023 • edited

AtariDreams commented Feb 28, 2023

webkit-early-warning-system commented Feb 28, 2023 • edited

AtariDreams commented Feb 28, 2023

webkit-early-warning-system commented Feb 28, 2023 • edited

rniwa left a comment

Choose a reason for hiding this comment

AtariDreams commented Mar 13, 2023

webkit-early-warning-system commented Mar 13, 2023 • edited

webkit-commit-queue commented Mar 13, 2023

AtariDreams commented Feb 26, 2023 •

edited by webkit-early-warning-system

`da93445`

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

rniwa commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Mar 13, 2023 •

edited