Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][WP] Block access to file-ioctl commands #1070

Merged
merged 0 commits into from May 26, 2022
Merged

[iOS][WP] Block access to file-ioctl commands #1070

merged 0 commits into from May 26, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented May 26, 2022 •
edited by webkit-early-warning-system

1bebfc4

[iOS][WP] Block access to file-ioctl commands
https://bugs.webkit.org/show_bug.cgi?id=240977
<rdar://88334007 >

Reviewed by Chris Dumez.

This is based on collected telemetry. This patch also adds telemetry to file read/write of /dev/aes_0
to determine if that can be removed as well.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: https://commits.webkit.org/251026@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pvollan pvollan self-assigned this May 26, 2022
@pvollan pvollan added Safari 15 WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). labels May 26, 2022
@pvollan pvollan force-pushed the eng/iOSWP-Block-access-to-file-ioctl-commands branch from 88c541f to 70fba3e Compare May 26, 2022 21:15
@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label May 26, 2022
@pvollan
Copy link
Contributor Author

pvollan commented May 26, 2022

Thanks for reviewing!

@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/iOSWP-Block-access-to-file-ioctl-commands branch from 70fba3e to 1bebfc4 Compare May 26, 2022 22:35
@webkit-early-warning-system webkit-early-warning-system merged commit 1bebfc4 into WebKit:main May 26, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294903 (251026@main): https://commits.webkit.org/251026@main

Reviewed commits have been landed. Closing PR #1070 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2022
guijemont pushed a commit to guijemont/WebKit that referenced this pull request Aug 30, 2023
@magomez
Merge pull request WebKit#1070 from WebPlatformForEmbedded/pgorszkows…
7a5d98b 
…ki/wpe-2.38/fix_crash_for_setCookieJar

Fix crash for setCookieJar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

@szewai szewai Awaiting requested review from szewai

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
3 participants
@pvollan @webkit-early-warning-system @cdumez