Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect #10703

squelart · 2023-02-26T23:08:07Z

`b9dad07`

Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect
https://bugs.webkit.org/show_bug.cgi?id=252967
rdar://problem/105952126

Reviewed by Tim Nguyen.

Instead of sending a CustomEvent with some hand-picked details, a click on the save button now dispatches a full copy of the original MouseEvent, and the location of the (shadow) save button can be found the element's saveButtonClientRect property.

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::saveButtonClientRect const):
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/html/HTMLAttachmentElement.idl:

Canonical link: https://commits.webkit.org/261101@main

f9644dc

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-26T23:10:01Z

EWS run on previous version of this PR (hash b559cda)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 mac-wk1~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-27T01:34:31Z

EWS run on previous version of this PR (hash 977ead6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

squelart · 2023-02-27T04:00:59Z

Dear reviewers: @nt1m suggested I should try to use a standard MouseEvent, and give the client another way to retrieve the save button's location after that. I'll update later, when I hear back from the main client...

webkit-early-warning-system · 2023-03-01T04:37:06Z

EWS run on previous version of this PR (hash ab03e0d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk2~~
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

nt1m

Looks good, would be nice to have test coverage

nt1m · 2023-03-01T04:50:38Z

You can manually enable flags in tests fwiw: 

squelart · 2023-03-01T04:58:18Z

Tests to be added in rdar://105474304 .

webkit-early-warning-system · 2023-03-01T05:01:48Z

EWS run on previous version of this PR (hash 7feb57b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	⏳ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk2~~
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/html/HTMLAttachmentElement.cpp

webkit-early-warning-system · 2023-03-01T06:07:41Z

EWS run on previous version of this PR (hash 176a7b7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

nt1m · 2023-03-01T23:28:59Z

Source/WebCore/html/HTMLAttachmentElement.cpp

+            auto copiedEvent = MouseEvent::create(
+                m_attachment->attributeWithoutSynchronization(saveAttr()), Event::CanBubble::No, Event::IsCancelable::No, Event::IsComposed::No,
+                mouseEvent.view(), mouseEvent.detail(), mouseEvent.screenX(), mouseEvent.screenY(), mouseEvent.clientX(), mouseEvent.clientY(),
+                mouseEvent.modifierKeys(), mouseEvent.button(), mouseEvent.buttons(), mouseEvent.syntheticClickType(), mouseEvent.relatedTarget());


relatedTarget() should probably be nullptr, see https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/relatedTarget

webkit-early-warning-system · 2023-03-01T23:36:08Z

EWS run on current version of this PR (hash f9644dc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

…lement's saveButtonClientRect https://bugs.webkit.org/show_bug.cgi?id=252967 rdar://problem/105952126 Reviewed by Tim Nguyen. Instead of sending a CustomEvent with some hand-picked details, a click on the save button now dispatches a full copy of the original MouseEvent, and the location of the (shadow) save button can be found the element's saveButtonClientRect property. * Source/WebCore/html/HTMLAttachmentElement.cpp: (WebCore::HTMLAttachmentElement::saveButtonClientRect const): * Source/WebCore/html/HTMLAttachmentElement.h: * Source/WebCore/html/HTMLAttachmentElement.idl: Canonical link: https://commits.webkit.org/261101@main

webkit-commit-queue · 2023-03-02T22:44:44Z

Committed 261101@main (b9dad07): https://commits.webkit.org/261101@main

Reviewed commits have been landed. Closing PR #10703 and removing active labels.

squelart requested review from cdumez and rniwa as code owners February 26, 2023 23:08

squelart self-assigned this Feb 26, 2023

squelart added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Feb 26, 2023

squelart force-pushed the eng/attachment-save-event-details branch from b559cda to 977ead6 Compare February 27, 2023 01:34

squelart changed the title ~~Add details in save's CustomEvent.details~~ Add details in attachment's save button's CustomEvent Feb 27, 2023

squelart marked this pull request as draft February 28, 2023 07:39

squelart force-pushed the eng/attachment-save-event-details branch from 977ead6 to ab03e0d Compare March 1, 2023 04:37

squelart changed the title ~~Add details in attachment's save button's CustomEvent~~ Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect Mar 1, 2023

nt1m reviewed Mar 1, 2023

View reviewed changes

squelart force-pushed the eng/attachment-save-event-details branch from ab03e0d to 7feb57b Compare March 1, 2023 05:01

squelart requested a review from nt1m March 1, 2023 05:02

nt1m approved these changes Mar 1, 2023

View reviewed changes

Source/WebCore/html/HTMLAttachmentElement.cpp Outdated Show resolved Hide resolved

Source/WebCore/html/HTMLAttachmentElement.cpp Outdated Show resolved Hide resolved

Source/WebCore/html/HTMLAttachmentElement.cpp Outdated Show resolved Hide resolved

squelart force-pushed the eng/attachment-save-event-details branch from 7feb57b to 176a7b7 Compare March 1, 2023 06:07

squelart requested a review from nt1m March 1, 2023 06:09

squelart marked this pull request as ready for review March 1, 2023 23:24

nt1m reviewed Mar 1, 2023

View reviewed changes

nt1m approved these changes Mar 1, 2023

View reviewed changes

squelart force-pushed the eng/attachment-save-event-details branch from 176a7b7 to f9644dc Compare March 1, 2023 23:35

nt1m added the merge-queue Applied to send a pull request to merge-queue label Mar 2, 2023

webkit-early-warning-system force-pushed the eng/attachment-save-event-details branch from f9644dc to b9dad07 Compare March 2, 2023 22:44

webkit-early-warning-system merged commit b9dad07 into WebKit:main Mar 2, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect #10703

Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect #10703

squelart commented Feb 26, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

squelart commented Feb 27, 2023

webkit-early-warning-system commented Mar 1, 2023 •

edited

nt1m left a comment

nt1m commented Mar 1, 2023

squelart commented Mar 1, 2023

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

nt1m Mar 1, 2023

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-commit-queue commented Mar 2, 2023

Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect #10703

Clicking on save button dispatches a MouseEvent, button location in element's saveButtonClientRect #10703

Conversation

squelart commented Feb 26, 2023 • edited by webkit-early-warning-system

b9dad07

webkit-early-warning-system commented Feb 26, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

squelart commented Feb 27, 2023

webkit-early-warning-system commented Mar 1, 2023 • edited

nt1m left a comment

Choose a reason for hiding this comment

nt1m commented Mar 1, 2023

squelart commented Mar 1, 2023

webkit-early-warning-system commented Mar 1, 2023 • edited

webkit-early-warning-system commented Mar 1, 2023 • edited

nt1m Mar 1, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Mar 1, 2023 • edited

webkit-commit-queue commented Mar 2, 2023

squelart commented Feb 26, 2023 •

edited by webkit-early-warning-system

`b9dad07`

webkit-early-warning-system commented Feb 26, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited