[GLib] New API to get the request body of WebKitURISchemeRequest #10714

wusyong · 2023-02-27T06:52:22Z

`5fe923a`

[GLib] New API to get the request body of WebKitURISchemeRequest
https://bugs.webkit.org/show_bug.cgi?id=252564

Reviewed by Carlos Garcia Campos, Michael Catanzaro and Adrian Perez de Castro.

* Source/WebCore/platform/network/soup/ResourceRequest.h:
* Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::createInputStream const): Added new function
API
* Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp:
(webkit_uri_scheme_request_get_http_body): Added new function API
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextURIScheme): Expanded 'post' URI scheme to test
webkit_uri_scheme_request_get_http_body

Canonical link: https://commits.webkit.org/260949@main

1d216ea

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-27T06:52:28Z

EWS run on previous version of this PR (hash e3384ed)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

aperezdc

Thanks for the patch @wusyong, this looks neat 🏗️

We have just branched for 2.40 recently, but IMO this is quite nice to have and should be fine to add into the release branch if @carlosgcampos or @mcatanzaro agree—the patch is self-contained, only adds one public method, and comes with a test. WDYT?

(As with any API change, we need a second approval before landing, so let's wait and see what the other reviewers think.)

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp

aperezdc · 2023-02-27T08:43:49Z

@wusyong I have changed the Bugzilla issue title to “[GLib] New API to get the request body of WebKitURISchemeRequest” because to better reflect what the feature is about, and also because it also bring the new API to the WPE port (GLib = GTK + WPE). Could you change the first line of the commit log accordingly? Thanks! 🙏🏼

webkit-early-warning-system · 2023-02-27T09:00:11Z

EWS run on previous version of this PR (hash b017a81)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk2~~	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-27T09:04:28Z

EWS run on previous version of this PR (hash 978112b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

carlosgcampos · 2023-02-27T10:24:53Z

Looks good to me, but I wonder if it would be easier to expose the body as a GBytes instead. In this case, the body is always serialized over IPC, so it fits in memory, and it's not expected to be processed as a stream, I guess.

mcatanzaro

Good work.

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

mcatanzaro · 2023-02-27T16:03:02Z

Looks good to me, but I wonder if it would be easier to expose the body as a GBytes instead. In this case, the body is always serialized over IPC, so it fits in memory, and it's not expected to be processed as a stream, I guess.

GBytes is fine. Or simply unsigned char * or uint8_t *.

webkit-early-warning-system · 2023-02-27T16:17:04Z

EWS run on previous version of this PR (hash 5fa5f51)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~
	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

wusyong · 2023-02-27T16:18:38Z

I'll stick to GBytes since many APIs also return this type for bytes. I've updated the return type to GBytes. Please let me know if I missed anything.

mcatanzaro

By the way: it's very unusual for your first contribution to be new public API, so congrats on that. This is simple, adequately tested, and looks good.

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp

webkit-early-warning-system · 2023-02-27T17:33:46Z

EWS run on previous version of this PR (hash de12c04)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp

mcatanzaro · 2023-02-27T19:16:25Z

One last thing: please squash your two commits into one. We can't land pull requests with multiple commits for WebKit-specific reasons. So please fix that, and make the one-line change that I proposed above, and then this is good to go. And we'll backport to 2.40 as well so you can use it sooner rather than later.

webkit-early-warning-system · 2023-02-28T01:04:32Z

EWS run on previous version of this PR (hash cf8fdad)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp

webkit-early-warning-system · 2023-02-28T02:16:06Z

EWS run on previous version of this PR (hash 3f5fcd4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

webkit-early-warning-system · 2023-02-28T11:40:04Z

EWS run on previous version of this PR (hash cb97834)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/platform/network/soup/ResourceRequest.h

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp

webkit-early-warning-system · 2023-02-28T14:06:04Z

EWS run on previous version of this PR (hash 9b57d27)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
~~🛠 🧪 merge~~	✅ 🛠 watch-sim

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp

webkit-early-warning-system · 2023-02-28T15:12:23Z

EWS run on current version of this PR (hash 1d216ea)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=252564 Reviewed by Carlos Garcia Campos, Michael Catanzaro and Adrian Perez de Castro. * Source/WebCore/platform/network/soup/ResourceRequest.h: * Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::createInputStream const): Added new function API * Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.h.in: * Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp: (webkit_uri_scheme_request_get_http_body): Added new function API * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: (testWebContextURIScheme): Expanded 'post' URI scheme to test webkit_uri_scheme_request_get_http_body Canonical link: https://commits.webkit.org/260949@main

webkit-commit-queue · 2023-02-28T17:43:22Z

Committed 260949@main (5fe923a): https://commits.webkit.org/260949@main

Reviewed commits have been landed. Closing PR #10714 and removing active labels.

wusyong requested a review from a team as a code owner February 27, 2023 06:52

aperezdc approved these changes Feb 27, 2023

View reviewed changes

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from e3384ed to b017a81 Compare February 27, 2023 09:00

wusyong changed the title ~~[GTK] Get the HTTP body of WebKitURISchemeRequest~~ [GLib] Get the HTTP body of WebKitURISchemeRequest Feb 27, 2023

wusyong force-pushed the request branch from b017a81 to 978112b Compare February 27, 2023 09:04

wusyong changed the title ~~[GLib] Get the HTTP body of WebKitURISchemeRequest~~ [GLib] New API to get the request body of WebKitURISchemeRequest Feb 27, 2023

aperezdc requested review from mcatanzaro and carlosgcampos February 27, 2023 09:24

aperezdc added WebKit API For issues and bugs in the Web Kit public embedding APIs WebKitGTK Bugs related to the Gtk API layer. WPE WebKit WebKit WPE component labels Feb 27, 2023

mcatanzaro reviewed Feb 27, 2023

View reviewed changes

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp Show resolved Hide resolved

wusyong force-pushed the request branch from 978112b to 5fa5f51 Compare February 27, 2023 16:16

mcatanzaro approved these changes Feb 27, 2023

View reviewed changes

mcatanzaro reviewed Feb 27, 2023

View reviewed changes

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from de12c04 to cf8fdad Compare February 28, 2023 01:04

mcatanzaro approved these changes Feb 28, 2023

View reviewed changes

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp Outdated Show resolved Hide resolved

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from cf8fdad to 3f5fcd4 Compare February 28, 2023 02:15

carlosgcampos requested changes Feb 28, 2023

View reviewed changes

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp Outdated Show resolved Hide resolved

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from 3f5fcd4 to cb97834 Compare February 28, 2023 11:39

carlosgcampos requested changes Feb 28, 2023

View reviewed changes

Source/WebCore/platform/network/soup/ResourceRequest.h Outdated Show resolved Hide resolved

Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp Outdated Show resolved Hide resolved

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from cb97834 to 9b57d27 Compare February 28, 2023 14:05

carlosgcampos approved these changes Feb 28, 2023

View reviewed changes

aperezdc added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023

mcatanzaro removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023

mcatanzaro reviewed Feb 28, 2023

View reviewed changes

Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp Outdated Show resolved Hide resolved

wusyong force-pushed the request branch from 9b57d27 to 1d216ea Compare February 28, 2023 15:12

mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023

webkit-early-warning-system force-pushed the request branch from 1d216ea to 5fe923a Compare February 28, 2023 17:43

webkit-early-warning-system merged commit 5fe923a into WebKit:main Feb 28, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023

wusyong deleted the request branch March 1, 2023 11:58

ModProg mentioned this pull request Sep 11, 2023

[feat] access to URISchemeRequest body on Linux tauri-apps/wry#666

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GLib] New API to get the request body of WebKitURISchemeRequest #10714

[GLib] New API to get the request body of WebKitURISchemeRequest #10714

wusyong commented Feb 27, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 27, 2023 •

edited

aperezdc left a comment

aperezdc commented Feb 27, 2023

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

carlosgcampos commented Feb 27, 2023

mcatanzaro left a comment

mcatanzaro commented Feb 27, 2023

webkit-early-warning-system commented Feb 27, 2023 •

edited

wusyong commented Feb 27, 2023

mcatanzaro left a comment

webkit-early-warning-system commented Feb 27, 2023 •

edited

mcatanzaro commented Feb 27, 2023

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-commit-queue commented Feb 28, 2023

[GLib] New API to get the request body of WebKitURISchemeRequest #10714

[GLib] New API to get the request body of WebKitURISchemeRequest #10714

Conversation

wusyong commented Feb 27, 2023 • edited by webkit-early-warning-system

5fe923a

webkit-early-warning-system commented Feb 27, 2023 • edited

aperezdc left a comment

Choose a reason for hiding this comment

aperezdc commented Feb 27, 2023

webkit-early-warning-system commented Feb 27, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

carlosgcampos commented Feb 27, 2023

mcatanzaro left a comment

Choose a reason for hiding this comment

mcatanzaro commented Feb 27, 2023

webkit-early-warning-system commented Feb 27, 2023 • edited

wusyong commented Feb 27, 2023

mcatanzaro left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 27, 2023 • edited

mcatanzaro commented Feb 27, 2023

webkit-early-warning-system commented Feb 28, 2023 • edited

webkit-early-warning-system commented Feb 28, 2023 • edited

webkit-early-warning-system commented Feb 28, 2023 • edited

webkit-early-warning-system commented Feb 28, 2023 • edited

webkit-early-warning-system commented Feb 28, 2023 • edited

webkit-commit-queue commented Feb 28, 2023

wusyong commented Feb 27, 2023 •

edited by webkit-early-warning-system

`5fe923a`

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited

webkit-early-warning-system commented Feb 28, 2023 •

edited