Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also macOS has the Mach bootstrap sandbox extension #10733

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Also macOS has the Mach bootstrap sandbox extension #10733

merged 1 commit into from
Mar 7, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Feb 27, 2023 •
edited by webkit-early-warning-system

f2a535b

Also macOS has the Mach bootstrap sandbox extension
https://bugs.webkit.org/show_bug.cgi?id=252995

Reviewed by Geoffrey Garen.

* Source/WTF/wtf/PlatformHave.h:

Canonical link: https://commits.webkit.org/261310@main

5ccb277

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🧪 jsc-mips-tests

@pvollan pvollan self-assigned this Feb 27, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Feb 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5ccb277)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🧪 jsc-mips-tests

geoffreygaren
geoffreygaren approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan
Copy link
Contributor Author

pvollan commented Feb 28, 2023

r=me

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 7, 2023
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Also-macOS-has-the-Mach-bootstrap-sandbox-extension branch from 5ccb277 to f2a535b Compare March 7, 2023 07:26
@webkit-commit-queue
Copy link
Collaborator

Committed 261310@main (f2a535b): https://commits.webkit.org/261310@main

Reviewed commits have been landed. Closing PR #10733 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f2a535b into WebKit:main Mar 7, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @geoffreygaren