Do not coalesce unspillable tmps #10742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmichaud
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 1a17163) |
justinmichaud
force-pushed
the
eng/Do-not-coalesce-unspillable-tmps
branch
from
1a17163
to
3470cc3
Compare
|
EWS run on previous version of this PR (hash 3470cc3) |
justinmichaud
force-pushed
the
eng/Do-not-coalesce-unspillable-tmps
branch
from
3470cc3
to
ef2c550
Compare
|
Perf is neutral on JS2 AS, landing |
justinmichaud
added
the
merge-queue
|
EWS run on current version of this PR (hash ef2c550) |
https://bugs.webkit.org/show_bug.cgi?id=253006 rdar://105878987 Reviewed by Yusuke Suzuki. We have been encountering multiple test cases where we make a graph uncolourable by coalescing too aggressively. If a tmp is marked as unspillable because its live range is too small, it will never be un-marked if it gets coalesced. Let's try not coalescing these registers ever. * Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp: Canonical link: https://commits.webkit.org/260969@main
webkit-early-warning-system
force-pushed
the
eng/Do-not-coalesce-unspillable-tmps
branch
from
ef2c550
to
c83189e
Compare
|
Committed 260969@main (c83189e): https://commits.webkit.org/260969@main Reviewed commits have been landed. Closing PR #10742 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c83189e
ef2c550
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🛠 🧪 jsc🧪 mac-wk2🧪 mac-AS-debug-wk2