Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WTF::safeAdd returns twice #10754

Merged
merged 1 commit into from
Feb 28, 2023
Merged

WTF::safeAdd returns twice #10754

merged 1 commit into from
Feb 28, 2023

Conversation

szewai
Copy link
Contributor

@szewai szewai commented Feb 27, 2023 •
edited by webkit-early-warning-system

fcb19eb

WTF::safeAdd returns twice
https://bugs.webkit.org/show_bug.cgi?id=253021
rdar://105991124

Reviewed by Chris Dumez.

Remove one return statement.

* Source/WTF/wtf/CheckedArithmetic.h:
(WTF::safeAdd):

Canonical link: https://commits.webkit.org/260915@main

2f6b5c8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@szewai szewai self-assigned this Feb 27, 2023
@szewai szewai added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 2f6b5c8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@szewai szewai added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
@szewai
WTF::safeAdd returns twice
fcb19eb 
https://bugs.webkit.org/show_bug.cgi?id=253021
rdar://105991124

Reviewed by Chris Dumez.

Remove one return statement.

* Source/WTF/wtf/CheckedArithmetic.h:
(WTF::safeAdd):

Canonical link: https://commits.webkit.org/260915@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260915@main (fcb19eb): https://commits.webkit.org/260915@main

Reviewed commits have been landed. Closing PR #10754 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit fcb19eb into WebKit:main Feb 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@szewai szewai

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@szewai @webkit-early-warning-system @webkit-commit-queue @cdumez