Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Add Brotli targets #10759

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Feb 27, 2023

ed51133

[CMake] Add Brotli targets
https://bugs.webkit.org/show_bug.cgi?id=253025

Reviewed by Michael Catanzaro.

The Windows port needs to link in Brotli's decoder library to support
WOFF2 so turn it into a proper find module. The module itself is the
same as the WOFF2 module. Update the WebCore library listing to use the
target.

The module will also be used by the PlayStation port in the near future.

* Source/WebCore/PlatformWin.cmake:
* Source/cmake/FindBrotli.cmake: Added.
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/260954@main

90444b9

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv ❌ πŸ§ͺ mac-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
  πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@donny-dont donny-dont self-assigned this Feb 27, 2023
@donny-dont donny-dont added the CMake Bugzilla component for CMake build system changes label Feb 27, 2023
@donny-dont donny-dont added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Feb 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=253025

Reviewed by Michael Catanzaro.

The Windows port needs to link in Brotli's decoder library to support
WOFF2 so turn it into a proper find module. The module itself is the
same as the WOFF2 module. Update the WebCore library listing to use the
target.

The module will also be used by the PlayStation port in the near future.

* Source/WebCore/PlatformWin.cmake:
* Source/cmake/FindBrotli.cmake: Added.
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/260954@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260954@main (ed51133): https://commits.webkit.org/260954@main

Reviewed commits have been landed. Closing PR #10759 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit ed51133 into WebKit:main Feb 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Bugzilla component for CMake build system changes
Projects
None yet
4 participants