Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Apple Compression API in Compression Streams #10768

Conversation

stwrt
Copy link
Member

@stwrt stwrt commented Feb 28, 2023

fe58e5c

Disable Apple Compression API in Compression Streams
https://bugs.webkit.org/show_bug.cgi?id=253042

Reviewed by Brent Fulgham.

Disable Compression API for Compression Streams right now as it is causing issues
on web sites.

* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::decompress):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.h:
(WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder):

Canonical link: https://commits.webkit.org/260923@main

7b82fa2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@stwrt stwrt self-assigned this Feb 28, 2023
@stwrt stwrt added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 28, 2023
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest you file a radar to add these back once the Compression framework fixes the bug.

@stwrt stwrt added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=253042

Reviewed by Brent Fulgham.

Disable Compression API for Compression Streams right now as it is causing issues
on web sites.

* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::decompress):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.h:
(WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder):

Canonical link: https://commits.webkit.org/260923@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Disable-Apple-Compression-API-in-Compression-Streams branch from 7b82fa2 to fe58e5c Compare February 28, 2023 05:46
@webkit-commit-queue
Copy link
Collaborator

Committed 260923@main (fe58e5c): https://commits.webkit.org/260923@main

Reviewed commits have been landed. Closing PR #10768 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit fe58e5c into WebKit:main Feb 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
@stwrt stwrt deleted the eng/Disable-Apple-Compression-API-in-Compression-Streams branch May 23, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants