Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-source-webm-vorbis-partial.html no longer fails #10775

Merged
merged 1 commit into from Feb 28, 2023
Merged

media-source-webm-vorbis-partial.html no longer fails #10775

merged 1 commit into from Feb 28, 2023

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Feb 28, 2023 •
edited by webkit-early-warning-system

9babab7

media-source-webm-vorbis-partial.html no longer fails
https://bugs.webkit.org/show_bug.cgi?id=253047
rdar://106009757

Reviewed by Jer Noble.

The test passes on Monterey and there's no reason for it to fail on BigSur.

* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/260929@main

7978bfd

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jyavenard jyavenard self-assigned this Feb 28, 2023
@jyavenard jyavenard added the Media Bugs related to the HTML 5 Media elements. label Feb 28, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7978bfd)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

jernoble
jernoble approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@jernoble jernoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
@jyavenard
media-source-webm-vorbis-partial.html no longer fails
9babab7 
https://bugs.webkit.org/show_bug.cgi?id=253047
rdar://106009757

Reviewed by Jer Noble.

The test passes on Monterey and there's no reason for it to fail on BigSur.

* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/260929@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/media-source-webm-vorbis-partial-html-no-longer-fails branch from 7978bfd to 9babab7 Compare February 28, 2023 11:25
@webkit-early-warning-system webkit-early-warning-system merged commit 9babab7 into WebKit:main Feb 28, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 260929@main (9babab7): https://commits.webkit.org/260929@main

Reviewed commits have been landed. Closing PR #10775 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernoble jernoble jernoble approved these changes

Assignees

@jyavenard jyavenard

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@jyavenard @webkit-early-warning-system @webkit-commit-queue @jernoble