[UI-side compositing] Hook up the MomentumEventGenerator for UI-side scrolling #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
Scrolling
|
EWS run on previous version of this PR (hash 2ad39d1)
|
hortont424
approved these changes
Feb 28, 2023
smfr
force-pushed
the
eng/UI-side-compositing-Hook-up-the-MomentumEventGenerator-for-UI-side-scrolling
branch
from
2ad39d1
to
ca94261
Compare
|
EWS run on current version of this PR (hash ca94261)
|
webkit-commit-queue
force-pushed
the
eng/UI-side-compositing-Hook-up-the-MomentumEventGenerator-for-UI-side-scrolling
branch
from
ca94261
to
976394c
Compare
…scrolling https://bugs.webkit.org/show_bug.cgi?id=253049 rdar://106012308 Reviewed by Tim Horton. Give RemoteLayerTreeEventDispatcher a MomentumEventDispatcher, which synthesizes momentum events on the UI-sides scrolling thread. RemoteLayerTreeEventDispatcher becomes a MomentumEventDispatcher::Client so that MomentumEventDispatcher can keep the display link alive. Fix startOrStopDisplayLink() so it can be called from either thread. RemoteLayerTreeEventDispatcher::willHandleWheelEvent() is used so allow the MomentumEventDispatcher to extract the ScrollingAccelerationCurve from the native event. Factor code into determineWheelEventProcessing() so we can call it before feeding events to MomentumEventDispatcher, because we need to know if this event is relevant to the scrolling thread before handing it off to MomentumEventDispatcher, which can't give an answer about whether it's handled. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::RemoteLayerTreeEventDispatcher::create): (WebKit::RemoteLayerTreeEventDispatcher::RemoteLayerTreeEventDispatcher): (WebKit::m_momentumEventDispatcher): (WebKit::RemoteLayerTreeEventDispatcher::wheelEventHysteresisUpdated): (WebKit::RemoteLayerTreeEventDispatcher::hasNodeWithAnimatedScrollChanged): (WebKit::RemoteLayerTreeEventDispatcher::willHandleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::handleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::determineWheelEventProcessing): (WebKit::RemoteLayerTreeEventDispatcher::scrollingThreadHandleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::internalHandleWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::startOrStopDisplayLink): (WebKit::RemoteLayerTreeEventDispatcher::startOrStopDisplayLinkOnMainThread): (WebKit::RemoteLayerTreeEventDispatcher::didRefreshDisplay): (WebKit::RemoteLayerTreeEventDispatcher::mainThreadDisplayDidRefresh): (WebKit::RemoteLayerTreeEventDispatcher::windowScreenDidChange): (WebKit::RemoteLayerTreeEventDispatcher::handleSyntheticWheelEvent): (WebKit::RemoteLayerTreeEventDispatcher::startDisplayDidRefreshCallbacks): (WebKit::RemoteLayerTreeEventDispatcher::stopDisplayDidRefreshCallbacks): (WebKit::RemoteLayerTreeEventDispatcher::flushMomentumEventLoggingSoon): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h: * Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h: Canonical link: https://commits.webkit.org/260976@main
webkit-commit-queue
force-pushed
the
eng/UI-side-compositing-Hook-up-the-MomentumEventGenerator-for-UI-side-scrolling
branch
from
976394c
to
7b321c9
Compare
|
Committed 260976@main (7b321c9): https://commits.webkit.org/260976@main Reviewed commits have been landed. Closing PR #10778 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
smfr
deleted the
eng/UI-side-compositing-Hook-up-the-MomentumEventGenerator-for-UI-side-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7b321c9
ca94261
🛠 mac🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress