Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screen Orientation API] Change natural orientation on iPad and TV to be landscape-primary #10803

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[Screen Orientation API] Change natural orientation on iPad and TV to be landscape-primary #10803

merged 1 commit into from
Mar 1, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 28, 2023 •
edited by webkit-early-warning-system

f022496

[Screen Orientation API] Change natural orientation on iPad and TV to be landscape-primary
https://bugs.webkit.org/show_bug.cgi?id=253082

Reviewed by Darin Adler.

Change natural orientation on iPad and TV to be landscape-primary instead of
portrait-primary.

* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ScreenOrientationType.h:
(WebCore::isPortrait):
(WebCore::naturalScreenOrientationType):
(WebCore::isPortait): Deleted.
* Source/WebCore/platform/ios/Device.h:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::resolveScreenOrientationLockType):

Canonical link: https://commits.webkit.org/260984@main

bcf6ea7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez self-assigned this Feb 28, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 28, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash bcf6ea7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez mentioned this pull request Feb 28, 2023
Merged
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 1, 2023
@cdumez
[Screen Orientation API] Change natural orientation on iPad and TV to…
f022496 
… be landscape-primary

https://bugs.webkit.org/show_bug.cgi?id=253082

Reviewed by Darin Adler.

Change natural orientation on iPad and TV to be landscape-primary instead of
portrait-primary.

* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ScreenOrientationType.h:
(WebCore::isPortrait):
(WebCore::naturalScreenOrientationType):
(WebCore::isPortait): Deleted.
* Source/WebCore/platform/ios/Device.h:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::resolveScreenOrientationLockType):

Canonical link: https://commits.webkit.org/260984@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260984@main (f022496): https://commits.webkit.org/260984@main

Reviewed commits have been landed. Closing PR #10803 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f022496 into WebKit:main Mar 1, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@darinadler darinadler darinadler approved these changes

@whsieh whsieh Awaiting requested review from whsieh

@hortont424 hortont424 Awaiting requested review from hortont424

Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @marcoscaceres @darinadler