[JSC] Hoist configurability checks in ProxyObject's "get" and "set" traps #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash a270a8f) |
shvaikalesh
added
the
unsafe-merge-queue
webkit-early-warning-system
force-pushed
the
eng/JSC-Hoist-configurability-checks-in-ProxyObjects-get-and-set-traps
branch
from
a270a8f
to
a0ff0ac
Compare
…raps https://bugs.webkit.org/show_bug.cgi?id=253083 <rdar://problem/106035527> Reviewed by Yusuke Suzuki. This patch implements editorial spec change [1], making the code a bit easier to read and sets the stage for a follow-up patch that will make the trap result validation conditional. No behavior change. [1]: tc39/ecma262#895 * Source/JavaScriptCore/runtime/ProxyObject.cpp: (JSC::ProxyObject::validateGetTrapResult): (JSC::ProxyObject::validateSetTrapResult): Canonical link: https://commits.webkit.org/260957@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Hoist-configurability-checks-in-ProxyObjects-get-and-set-traps
branch
from
a0ff0ac
to
2356400
Compare
|
Committed 260957@main (2356400): https://commits.webkit.org/260957@main Reviewed commits have been landed. Closing PR #10805 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2356400
a270a8f
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2