[UI-side compositing] Assertion under RemoteLayerTreeEventDispatcher::displayLink() running tests #10824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
Scrolling
|
EWS run on current version of this PR (hash d8ac764)
|
hortont424
approved these changes
Feb 28, 2023
…:displayLink() running tests https://bugs.webkit.org/show_bug.cgi?id=253112 rdar://106051454 Reviewed by Tim Horton. RemoteScrollingCoordinatorProxy owns a RemoteLayerTreeEventDispatcher which needs to get back to the DrawingAreaProxy to cancel a DisplayLink on cleanup. This means that the RemoteScrollingCoordinatorProxy needs to be destroyed before the DrawingAreaProxy, so ensure that in WebPageProxy. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDrawingArea): (WebKit::WebPageProxy::resetState): Call setDrawingArea(nullptr) so we run the same cleanup code. Canonical link: https://commits.webkit.org/260975@main
webkit-early-warning-system
force-pushed
the
eng/UI-side-compositing-Assertion-under-RemoteLayerTreeEventDispatcherdisplayLink-running-tests
branch
from
d8ac764
to
f249228
Compare
|
Committed 260975@main (f249228): https://commits.webkit.org/260975@main Reviewed commits have been landed. Closing PR #10824 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f249228
d8ac764
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2