Fetch/delete data store identifiers on a background thread #10826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szewai
added
the
New Bugs
|
EWS run on previous version of this PR (hash d72f566)
|
cdumez
requested changes
Mar 2, 2023
Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
Outdated
Show resolved
Hide resolved
Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
Outdated
Show resolved
Hide resolved
szewai
force-pushed
the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
from
d72f566
to
e4619f9
Compare
|
EWS run on current version of this PR (hash e4619f9)
|
🧪 style
|
EWS run on previous version of this PR (hash e4619f9)
|
szewai
force-pushed
the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
from
e4619f9
to
e76a28d
Compare
|
EWS run on previous version of this PR (hash e76a28d)
|
cdumez
approved these changes
Mar 2, 2023
| completionHandler(WTFMove(identifiers)); | ||
| websiteDataStoreIOQueue().dispatch([completionHandler = WTFMove(completionHandler), directory = defaultWebsiteDataStoreRootDirectory().isolatedCopy()]() mutable { | ||
| Vector<UUID> identifiers; | ||
| for (auto& identifierString : FileSystem::listDirectory(directory)) { |
There was a problem hiding this comment.
Would be nice to use compactMap() for this. It would be a bit shorter and more efficient.
Likely something like:
auto identifiers = WTF::compactMap(FileSystem::listDirectory(directory), [](auto& identifierString) { return UUID::parse(identifierString); });
e76a28d
to
482f28c
Compare
|
EWS run on previous version of this PR (hash 482f28c)
|
szewai
force-pushed
the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
from
482f28c
to
59ba50c
Compare
|
EWS run on current version of this PR (hash 59ba50c)
|
webkit-early-warning-system
force-pushed
the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
from
59ba50c
to
a17f673
Compare
https://bugs.webkit.org/show_bug.cgi?id=253113 rdar://106051983 Reviewed by Chris Dumez. These involves disk operations that should be performed on background thread. * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::fetchAllDataStoreIdentifiers): (WebKit::WebsiteDataStore::removeDataStoreWithIdentifier): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::websiteDataStoreIOQueue): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: Canonical link: https://commits.webkit.org/261187@main
webkit-early-warning-system
force-pushed
the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
from
a17f673
to
b085855
Compare
|
Committed 261187@main (b085855): https://commits.webkit.org/261187@main Reviewed commits have been landed. Closing PR #10826 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
szewai
deleted the
eng/Fetchdelete-data-store-identifiers-on-a-background-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b085855
59ba50c
🧪 wpe-wk2🧪 ios-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk2-stress🛠 watch-sim