Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Switch back to 0 painting threads #10830

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Feb 28, 2023

3f7115b

[GTK] Switch back to 0 painting threads
https://bugs.webkit.org/show_bug.cgi?id=253108

Reviewed by NOBODY (OOPS!).

We thought it might be safe to use 1 painting thread, but this does not
seem to be true, so go back to 0 for now.

I've also removed the DEVELOPER_MODE and platform preprocessor guards
because there's not really any need for them. It's fine to gate the
functionality behind an environment variable. The implementation is
compiled unconditionally anyway.

Lastly, change what happens when an invalid value is passed via the
environment variable. Currently the "default value" 4 is used only when
you pass an invalid value via the environment variable. That's pretty
strange -- it's "default" only in the sense of default to use when an
invalid value is selected -- so let's switch to using the actual default
value 0.

* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
(Nicosia::PaintingEngine::create):

3f7115b

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim

https://bugs.webkit.org/show_bug.cgi?id=253108

Reviewed by NOBODY (OOPS!).

We thought it might be safe to use 1 painting thread, but this does not
seem to be true, so go back to 0 for now.

I've also removed the DEVELOPER_MODE and platform preprocessor guards
because there's not really any need for them. It's fine to gate the
functionality behind an environment variable. The implementation is
compiled unconditionally anyway.

Lastly, change what happens when an invalid value is passed via the
environment variable. Currently the "default value" 4 is used only when
you pass an invalid value via the environment variable. That's pretty
strange -- it's "default" only in the sense of default to use when an
invalid value is selected -- so let's switch to using the actual default
value 0.

* Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
(Nicosia::PaintingEngine::create):
@mcatanzaro mcatanzaro self-assigned this Feb 28, 2023
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label Feb 28, 2023
@mcatanzaro mcatanzaro requested a review from a team February 28, 2023 23:33
@mcatanzaro
Copy link
Contributor Author

Marking as Draft because we might not need this after all. Carlos has posted an alternate solution in https://bugs.webkit.org/show_bug.cgi?id=247628

@mcatanzaro mcatanzaro marked this pull request as draft March 3, 2023 21:02
@mcatanzaro
Copy link
Contributor Author

Closing, let's do #11102 instead.

@mcatanzaro mcatanzaro closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
2 participants