[JSC] Consume unused Values #10840
Merged
[JSC] Consume unused Values #10840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 6579ae2) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=253125 rdar://106060228 Reviewed by Justin Michaud. These values are used for checking exception status. And they do not exist on WasmFunctionParser side's stack. So we should immediately consume these values to release them from temp stack. locationOf will find these values. And it is possible that they have different types & registers from the expected values' types & registers. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addTableSet): (JSC::Wasm::BBQJIT::addTableInit): (JSC::Wasm::BBQJIT::addTableFill): (JSC::Wasm::BBQJIT::addTableCopy): (JSC::Wasm::BBQJIT::addMemoryFill): (JSC::Wasm::BBQJIT::addMemoryCopy): (JSC::Wasm::BBQJIT::addMemoryInit): (JSC::Wasm::BBQJIT::clobbersForDivX86): (JSC::Wasm::BBQJIT::allocateWithHint): (JSC::Wasm::BBQJIT::bind): (JSC::Wasm::BBQJIT::evictGPR): (JSC::Wasm::BBQJIT::ScratchScope::bindGPRToScratch): (JSC::Wasm::BBQJIT::ScratchScope::unbindGPRFromScratch): (JSC::Wasm::BBQJIT::ScratchScope::initializedPreservedSet): Canonical link: https://commits.webkit.org/260979@main
webkit-commit-queue
force-pushed
the
eng/JSC-Consume-unused-Values
branch
from
6579ae2
to
2e8f9e4
Compare
|
Committed 260979@main (2e8f9e4): https://commits.webkit.org/260979@main Reviewed commits have been landed. Closing PR #10840 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2e8f9e4
6579ae2
🛠 mac🛠 wpe🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress