Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari doesn't translate shadow DOM content #10845

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Safari doesn't translate shadow DOM content #10845

merged 1 commit into from
Mar 2, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Mar 1, 2023 •
edited by webkit-early-warning-system

21659de

Safari doesn't translate shadow DOM content
https://bugs.webkit.org/show_bug.cgi?id=253130

Reviewed by Wenson Hsieh.

Recursively translate shadow DOM contents.

FWIW, Chrome doesn't seem to do any translation of shadow DOM contents.

* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::observeParagraphs):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261096@main

50a454f

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@rniwa rniwa self-assigned this Mar 1, 2023
@rniwa rniwa added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Mar 1, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 16ec7ad)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@rniwa rniwa requested review from szewai and whsieh March 1, 2023 03:43
@szewai
Copy link
Contributor

szewai commented Mar 1, 2023

The API test failure seems related

@rniwa
Copy link
Member Author

rniwa commented Mar 1, 2023

The API test failure seems related

Indeed. I need to skip UA shadow roots.

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 50a454f)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

whsieh
whsieh approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@whsieh whsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=mews

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 2, 2023
@rniwa
Safari doesn't translate shadow DOM content
21659de 
https://bugs.webkit.org/show_bug.cgi?id=253130

Reviewed by Wenson Hsieh.

Recursively translate shadow DOM contents.

FWIW, Chrome doesn't seem to do any translation of shadow DOM contents.

* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::observeParagraphs):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261096@main
@webkit-early-warning-system webkit-early-warning-system merged commit 21659de into WebKit:main Mar 2, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 261096@main (21659de): https://commits.webkit.org/261096@main

Reviewed commits have been landed. Closing PR #10845 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 2, 2023
@rniwa rniwa deleted the fix253130 branch March 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@szewai szewai Awaiting requested review from szewai

Assignees

@rniwa rniwa

Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @szewai @webkit-commit-queue @whsieh