Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop exposing ApplicationCache API if it is not enabled #1085

Merged
merged 0 commits into from May 27, 2022
Merged

Stop exposing ApplicationCache API if it is not enabled #1085

merged 0 commits into from May 27, 2022

Conversation

szewai
Copy link
Contributor

@szewai szewai commented May 27, 2022 •
edited by webkit-early-warning-system

84496ac

Stop exposing ApplicationCache API if it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=241000

Reviewed by Chris Dumez.

* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/loader/appcache/DOMApplicationCache.idl:
* Source/WebCore/page/DOMWindow.idl:

Canonical link: https://commits.webkit.org/251057@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@szewai szewai self-assigned this May 27, 2022
@szewai szewai added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels May 27, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 27, 2022
cdumez
cdumez approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szewai szewai added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 27, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 84496ac into WebKit:main May 27, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294949 (251057@main): https://commits.webkit.org/251057@main

Reviewed commits have been landed. Closing PR #1085 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 27, 2022
@szewai szewai deleted the eng/bug_241000 branch July 5, 2022 18:59
guijemont pushed a commit to guijemont/WebKit that referenced this pull request Aug 30, 2023
@emutavchi
Merge pull request WebKit#1085 from filipe-norte-red/wpe-2.38
5b40d9c 
Add ATK accessibility support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@szewai szewai

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
3 participants
@szewai @webkit-early-warning-system @cdumez