Add API to trigger background fetch click event #10856

youennf · 2023-03-01T11:11:02Z

`4a7cad9`

Add API to trigger background fetch click event
https://bugs.webkit.org/show_bug.cgi?id=253072
rdar://problem/106026054

Reviewed by Sihui Liu.

Expose new WebsiteDataStore API to get a list of background fetch identifiers, click, abort, pause and resume them.
Each call sends IPC to network process to do the actual work.
The work is done through BackgroundFetchStoreImpl that will identify the background fetch registration from the background fetch identifier.
The background fetch identifier is the filename of the persisted background fetch.
Once identified, we send the order to the BackgroundFetchEngine.
This patch only implements abort and click in BackgroundFetchEngine.

We add testRunner API to trigger click, abort, resume and suspend actions.

* LayoutTests/http/wpt/background-fetch/background-fetch-abort.window-expected.txt: Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.html: Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.js: Added.
(promise_test.async t):
* LayoutTests/http/wpt/background-fetch/background-fetch-click.window-expected.txt: Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-click.window.html: Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-click.window.js: Added.
(promise_test.async t):
* LayoutTests/http/wpt/background-fetch/sw.js:
(onmessage):
(onbackgroundfetchclick):
(onbackgroundfetchabort):
* Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp:
(WebCore::BackgroundFetchEngine::startBackgroundFetch):
(WebCore::BackgroundFetchEngine::backgroundFetchInformation):
(WebCore::BackgroundFetchEngine::backgroundFetchIdentifiers):
(WebCore::BackgroundFetchEngine::abortBackgroundFetch):
(WebCore::BackgroundFetchEngine::matchBackgroundFetch):
(WebCore::BackgroundFetchEngine::pauseBackgroundFetch):
(WebCore::BackgroundFetchEngine::resumeBackgroundFetch):
(WebCore::BackgroundFetchEngine::clickBackgroundFetch):
* Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h:
* Source/WebCore/workers/service/background-fetch/BackgroundFetchStore.h:
* Source/WebCore/workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::fireBackgroundFetchClickEvent):
* Source/WebCore/workers/service/context/SWContextManager.h:
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireBackgroundFetchClickEvent):
* Source/WebCore/workers/service/context/ServiceWorkerThread.h:
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::fireBackgroundFetchClickEvent):
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::fireBackgroundFetchEvent):
(WebCore::SWServer::fireBackgroundFetchClickEvent):
* Source/WebCore/workers/service/server/SWServer.h:
* Source/WebCore/workers/service/server/SWServerDelegate.h:
* Source/WebCore/workers/service/server/SWServerToContextConnection.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::allBackgroundFetches):
(WebKit::NetworkProcess::abortBackgroundFetch):
(WebKit::NetworkProcess::pauseBackgroundFetch):
(WebKit::NetworkProcess::resumeBackgroundFetch):
(WebKit::NetworkProcess::clickBackgroundFetch):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::createBackgroundFetchStore):
(WebKit::NetworkSession::ensureBackgroundFetchStore):
(WebKit::NetworkSession::allBackgroundFetches):
(WebKit::NetworkSession::abortBackgroundFetch):
(WebKit::NetworkSession::pauseBackgroundFetch):
(WebKit::NetworkSession::resumeBackgroundFetch):
(WebKit::NetworkSession::clickBackgroundFetch):
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::fireBackgroundFetchClickEvent):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
* Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp:
(WebKit::BackgroundFetchStoreImpl::BackgroundFetchStoreImpl):
(WebKit::BackgroundFetchStoreImpl::registerFetch):
(WebKit::BackgroundFetchStoreImpl::initializeFetches):
(WebKit::BackgroundFetchStoreImpl::storeFetch):
(WebKit::BackgroundFetchStoreImpl::fetchInformationFromFilename):
(WebKit::BackgroundFetchStoreImpl::loadAllFetches):
(WebKit::BackgroundFetchStoreImpl::allBackgroundFetches):
(WebKit::BackgroundFetchStoreImpl::abortBackgroundFetch):
(WebKit::BackgroundFetchStoreImpl::pauseBackgroundFetch):
(WebKit::BackgroundFetchStoreImpl::resumeBackgroundFetch):
(WebKit::BackgroundFetchStoreImpl::clickBackgroundFetch):
* Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.h:
(WebKit::BackgroundFetchStoreImpl::create):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::close):
(WebKit::NetworkStorageManager::writeOriginToFileIfNecessary):
(WebKit::NetworkStorageManager::originStorageManager):
(WebKit::NetworkStorageManager::removeOriginStorageManagerIfPossible):
(WebKit::NetworkStorageManager::persisted):
(WebKit::NetworkStorageManager::persist):
(WebKit::NetworkStorageManager::estimate):
(WebKit::NetworkStorageManager::resetStoragePersistedState):
(WebKit::NetworkStorageManager::clearStorageForWebPage):
(WebKit::NetworkStorageManager::cloneSessionStorageForWebPage):
(WebKit::NetworkStorageManager::didIncreaseQuota):
(WebKit::NetworkStorageManager::getAllOrigins):
(WebKit::NetworkStorageManager::suspend):
(WebKit::NetworkStorageManager::handleLowMemoryWarning):
(WebKit::NetworkStorageManager::syncLocalStorage):
(WebKit::NetworkStorageManager::resetQuotaForTesting):
(WebKit::NetworkStorageManager::resetQuotaUpdatedBasedOnUsageForTesting):
(WebKit::NetworkStorageManager::cancelConnectToStorageArea):
(WebKit::NetworkStorageManager::cloneSessionStorageNamespace):
(WebKit::NetworkStorageManager::cacheStorageClearMemoryRepresentation):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _getAllBackgroundFetches:]):
(-[WKWebsiteDataStore _abortBackgroundFetch:]):
(-[WKWebsiteDataStore _pauseBackgroundFetch:]):
(-[WKWebsiteDataStore _resumeBackgroundFetch:]):
(-[WKWebsiteDataStore _clickBackgroundFetch:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::allBackgroundFetches):
(WebKit::NetworkProcessProxy::abortBackgroundFetch):
(WebKit::NetworkProcessProxy::pauseBackgroundFetch):
(WebKit::NetworkProcessProxy::resumeBackgroundFetch):
(WebKit::NetworkProcessProxy::clickBackgroundFetch):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::fireBackgroundFetchClickEvent):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h:
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::getBackgroundFetchIdentifier):
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::getBackgroundFetchIdentifier):
(WTR::TestRunner::abortBackgroundFetch):
(WTR::TestRunner::pauseBackgroundFetch):
(WTR::TestRunner::resumeBackgroundFetch):
(WTR::TestRunner::simulateClickBackgroundFetch):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::getBackgroundFetchIdentifier):
(WTR::TestController::abortBackgroundFetch):
(WTR::TestController::pauseBackgroundFetch):
(WTR::TestController::resumeBackgroundFetch):
(WTR::TestController::simulateClickBackgroundFetch):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::getBackgroundFetchIdentifier):
(WTR::TestController::abortBackgroundFetch):
(WTR::TestController::pauseBackgroundFetch):
(WTR::TestController::resumeBackgroundFetch):
(WTR::TestController::simulateClickBackgroundFetch):

Canonical link: https://commits.webkit.org/261136@main

4f43c5b

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	~~🛠 tv~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-01T11:11:22Z

EWS run on previous version of this PR (hash 8083876)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

szewai

Are these SPIs only added for test runner, or it could be used for clients?
(If they will be used for WebKit clients I think we might want them to be more formal and performant. For example, in current version, it seems getting background identifiers will create origin managers for all origins and import background fetch data for all origins, which seems can lead to abandoned memory (i.e. the data may never be used by web clients))

Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp

Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h

Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

Source/WebKit/NetworkProcess/NetworkProcess.h

Source/WebCore/workers/service/context/SWContextManager.cpp

Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp

Source/WebKit/NetworkProcess/NetworkProcess.cpp

youennf · 2023-03-02T09:16:25Z

Are these SPIs only added for test runner, or it could be used for clients?

In the future, it would be clients.

(If they will be used for WebKit clients I think we might want them to be more formal and performant. For example, in current version, it seems getting background identifiers will create origin managers for all origins and import background fetch data for all origins, which seems can lead to abandoned memory (i.e. the data may never be used by web clients))

That is correct.
FWIW, in service workers, we are also loading all registrations of all origins.
There will probably be more service workers than background fetches.
Also, if a client supports background fetches, the client will most probably implement a way to display all the bg fetches, or at least display there are some ongoing background fetches.

That said, we may want to optimise this in the future.
The identifier could for instance contain the client origin in addition to the UUID, or we could have a single file that would allow mapping UUIDs to origins.
Or we can switch the SPI to expose ClientOrigin + UUID.

webkit-early-warning-system · 2023-03-02T10:58:35Z

EWS run on previous version of this PR (hash af26af6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-02T11:42:17Z

EWS run on previous version of this PR (hash 10b9abd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-03-02T12:13:46Z

EWS run on previous version of this PR (hash b488ab6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

szewai

r=me with comments, overall looks good

LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.js

Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp

Source/WebCore/workers/service/server/SWServer.cpp

Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp

Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h

Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp

szewai · 2023-03-03T09:57:25Z

Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp

@@ -61,22 +66,35 @@ String BackgroundFetchStoreImpl::getFilename(const ServiceWorkerRegistrationKey&
    return iterator->value.fetchToFilenames.get(std::make_pair(key.scope().string(), identifier));
 }

-void BackgroundFetchStoreImpl::initializeFetches(BackgroundFetchEngine& engine, const ServiceWorkerRegistrationKey& key, CompletionHandler<void()>&& callback)
+void BackgroundFetchStoreImpl::registerFetch(const ClientOrigin& origin, const ServiceWorkerRegistrationKey& key, const String& backgroundFetchIdentifier, String&& fetchStorageIdentifier)


Seems we will need to add unregisterFetch function, otherwise the map will just keep growing as long as the session lives

An unregisterFetch method is clearer than doing the work in clearFetch/clearAllFetches.
I'll update the patch accordingly.

An unregisterFetch is also less efficient, since for clearFetch/clearAllFetches, we are already doing the find.
Also, m_perClientOriginFetches is growing so that, if we initialize once, we do not try again to reinitialize.

Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h

webkit-early-warning-system · 2023-03-03T12:13:41Z

EWS run on current version of this PR (hash 4f43c5b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	~~🛠 tv~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=253072 rdar://problem/106026054 Reviewed by Sihui Liu. Expose new WebsiteDataStore API to get a list of background fetch identifiers, click, abort, pause and resume them. Each call sends IPC to network process to do the actual work. The work is done through BackgroundFetchStoreImpl that will identify the background fetch registration from the background fetch identifier. The background fetch identifier is the filename of the persisted background fetch. Once identified, we send the order to the BackgroundFetchEngine. This patch only implements abort and click in BackgroundFetchEngine. We add testRunner API to trigger click, abort, resume and suspend actions. * LayoutTests/http/wpt/background-fetch/background-fetch-abort.window-expected.txt: Added. * LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.html: Added. * LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.js: Added. (promise_test.async t): * LayoutTests/http/wpt/background-fetch/background-fetch-click.window-expected.txt: Added. * LayoutTests/http/wpt/background-fetch/background-fetch-click.window.html: Added. * LayoutTests/http/wpt/background-fetch/background-fetch-click.window.js: Added. (promise_test.async t): * LayoutTests/http/wpt/background-fetch/sw.js: (onmessage): (onbackgroundfetchclick): (onbackgroundfetchabort): * Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp: (WebCore::BackgroundFetchEngine::startBackgroundFetch): (WebCore::BackgroundFetchEngine::backgroundFetchInformation): (WebCore::BackgroundFetchEngine::backgroundFetchIdentifiers): (WebCore::BackgroundFetchEngine::abortBackgroundFetch): (WebCore::BackgroundFetchEngine::matchBackgroundFetch): (WebCore::BackgroundFetchEngine::pauseBackgroundFetch): (WebCore::BackgroundFetchEngine::resumeBackgroundFetch): (WebCore::BackgroundFetchEngine::clickBackgroundFetch): * Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchStore.h: * Source/WebCore/workers/service/context/SWContextManager.cpp: (WebCore::SWContextManager::fireBackgroundFetchClickEvent): * Source/WebCore/workers/service/context/SWContextManager.h: * Source/WebCore/workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::queueTaskToFireBackgroundFetchClickEvent): * Source/WebCore/workers/service/context/ServiceWorkerThread.h: * Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp: (WebCore::ServiceWorkerThreadProxy::fireBackgroundFetchClickEvent): * Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h: * Source/WebCore/workers/service/server/SWServer.cpp: (WebCore::SWServer::fireBackgroundFetchEvent): (WebCore::SWServer::fireBackgroundFetchClickEvent): * Source/WebCore/workers/service/server/SWServer.h: * Source/WebCore/workers/service/server/SWServerDelegate.h: * Source/WebCore/workers/service/server/SWServerToContextConnection.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::allBackgroundFetches): (WebKit::NetworkProcess::abortBackgroundFetch): (WebKit::NetworkProcess::pauseBackgroundFetch): (WebKit::NetworkProcess::resumeBackgroundFetch): (WebKit::NetworkProcess::clickBackgroundFetch): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::createBackgroundFetchStore): (WebKit::NetworkSession::ensureBackgroundFetchStore): (WebKit::NetworkSession::allBackgroundFetches): (WebKit::NetworkSession::abortBackgroundFetch): (WebKit::NetworkSession::pauseBackgroundFetch): (WebKit::NetworkSession::resumeBackgroundFetch): (WebKit::NetworkSession::clickBackgroundFetch): * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::fireBackgroundFetchClickEvent): * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp: (WebKit::BackgroundFetchStoreImpl::BackgroundFetchStoreImpl): (WebKit::BackgroundFetchStoreImpl::registerFetch): (WebKit::BackgroundFetchStoreImpl::initializeFetches): (WebKit::BackgroundFetchStoreImpl::storeFetch): (WebKit::BackgroundFetchStoreImpl::fetchInformationFromFilename): (WebKit::BackgroundFetchStoreImpl::loadAllFetches): (WebKit::BackgroundFetchStoreImpl::allBackgroundFetches): (WebKit::BackgroundFetchStoreImpl::abortBackgroundFetch): (WebKit::BackgroundFetchStoreImpl::pauseBackgroundFetch): (WebKit::BackgroundFetchStoreImpl::resumeBackgroundFetch): (WebKit::BackgroundFetchStoreImpl::clickBackgroundFetch): * Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.h: (WebKit::BackgroundFetchStoreImpl::create): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::close): (WebKit::NetworkStorageManager::writeOriginToFileIfNecessary): (WebKit::NetworkStorageManager::originStorageManager): (WebKit::NetworkStorageManager::removeOriginStorageManagerIfPossible): (WebKit::NetworkStorageManager::persisted): (WebKit::NetworkStorageManager::persist): (WebKit::NetworkStorageManager::estimate): (WebKit::NetworkStorageManager::resetStoragePersistedState): (WebKit::NetworkStorageManager::clearStorageForWebPage): (WebKit::NetworkStorageManager::cloneSessionStorageForWebPage): (WebKit::NetworkStorageManager::didIncreaseQuota): (WebKit::NetworkStorageManager::getAllOrigins): (WebKit::NetworkStorageManager::suspend): (WebKit::NetworkStorageManager::handleLowMemoryWarning): (WebKit::NetworkStorageManager::syncLocalStorage): (WebKit::NetworkStorageManager::resetQuotaForTesting): (WebKit::NetworkStorageManager::resetQuotaUpdatedBasedOnUsageForTesting): (WebKit::NetworkStorageManager::cancelConnectToStorageArea): (WebKit::NetworkStorageManager::cloneSessionStorageNamespace): (WebKit::NetworkStorageManager::cacheStorageClearMemoryRepresentation): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _getAllBackgroundFetches:]): (-[WKWebsiteDataStore _abortBackgroundFetch:]): (-[WKWebsiteDataStore _pauseBackgroundFetch:]): (-[WKWebsiteDataStore _resumeBackgroundFetch:]): (-[WKWebsiteDataStore _clickBackgroundFetch:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::allBackgroundFetches): (WebKit::NetworkProcessProxy::abortBackgroundFetch): (WebKit::NetworkProcessProxy::pauseBackgroundFetch): (WebKit::NetworkProcessProxy::resumeBackgroundFetch): (WebKit::NetworkProcessProxy::clickBackgroundFetch): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::fireBackgroundFetchClickEvent): * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h: * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in: * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::getBackgroundFetchIdentifier): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::getBackgroundFetchIdentifier): (WTR::TestRunner::abortBackgroundFetch): (WTR::TestRunner::pauseBackgroundFetch): (WTR::TestRunner::resumeBackgroundFetch): (WTR::TestRunner::simulateClickBackgroundFetch): * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::getBackgroundFetchIdentifier): (WTR::TestController::abortBackgroundFetch): (WTR::TestController::pauseBackgroundFetch): (WTR::TestController::resumeBackgroundFetch): (WTR::TestController::simulateClickBackgroundFetch): * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::getBackgroundFetchIdentifier): (WTR::TestController::abortBackgroundFetch): (WTR::TestController::pauseBackgroundFetch): (WTR::TestController::resumeBackgroundFetch): (WTR::TestController::simulateClickBackgroundFetch): Canonical link: https://commits.webkit.org/261136@main

webkit-commit-queue · 2023-03-03T13:55:13Z

Committed 261136@main (4a7cad9): https://commits.webkit.org/261136@main

Reviewed commits have been landed. Closing PR #10856 and removing active labels.

youennf requested review from cdumez and JonWBedard as code owners March 1, 2023 11:11

youennf self-assigned this Mar 1, 2023

youennf added the Service Workers Component for Service Workers bugs. label Mar 1, 2023

szewai reviewed Mar 2, 2023

View reviewed changes

youennf force-pushed the eng/Add-API-to-trigger-background-fetch-click-event branch from 8083876 to af26af6 Compare March 2, 2023 10:57

youennf force-pushed the eng/Add-API-to-trigger-background-fetch-click-event branch from af26af6 to 10b9abd Compare March 2, 2023 11:42

youennf force-pushed the eng/Add-API-to-trigger-background-fetch-click-event branch from 10b9abd to b488ab6 Compare March 2, 2023 12:13

youennf requested a review from szewai March 2, 2023 16:20

szewai approved these changes Mar 3, 2023

View reviewed changes

youennf force-pushed the eng/Add-API-to-trigger-background-fetch-click-event branch from b488ab6 to 4f43c5b Compare March 3, 2023 12:12

youennf added the merge-queue Applied to send a pull request to merge-queue label Mar 3, 2023

webkit-commit-queue force-pushed the eng/Add-API-to-trigger-background-fetch-click-event branch from 4f43c5b to 4a7cad9 Compare March 3, 2023 13:55

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 3, 2023

webkit-commit-queue merged commit 4a7cad9 into WebKit:main Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add API to trigger background fetch click event #10856

Add API to trigger background fetch click event #10856

youennf commented Mar 1, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 1, 2023 •

edited

szewai left a comment

youennf commented Mar 2, 2023

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

szewai left a comment

szewai Mar 3, 2023

youennf Mar 3, 2023

youennf Mar 3, 2023

webkit-early-warning-system commented Mar 3, 2023 •

edited

webkit-commit-queue commented Mar 3, 2023

Add API to trigger background fetch click event #10856

Add API to trigger background fetch click event #10856

Conversation

youennf commented Mar 1, 2023 • edited by webkit-early-warning-system

4a7cad9

webkit-early-warning-system commented Mar 1, 2023 • edited

szewai left a comment

Choose a reason for hiding this comment

youennf commented Mar 2, 2023

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

szewai left a comment

Choose a reason for hiding this comment

szewai Mar 3, 2023

Choose a reason for hiding this comment

youennf Mar 3, 2023

Choose a reason for hiding this comment

youennf Mar 3, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Mar 3, 2023 • edited

webkit-commit-queue commented Mar 3, 2023

youennf commented Mar 1, 2023 •

edited by webkit-early-warning-system

`4a7cad9`

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 3, 2023 •

edited